support msgpack 1.2.3 (1.4-maint) - #10469
Merged
ThomasWaldmann merged 1 commit intoSep 29, 2026
Merged
Conversation
msgpack 1.2.3 brings fixes relevant to borg's usage of the C extension: memory leaks when map key validation or container hooks fail (GHSA-j586-36cw-2gc2) and a use-after-free when cleaning up an incomplete Unpacker.skip(). The C Unpacker now raises ValueError when switching between unpack, skip, header readers or read_bytes() while an object is incomplete. borg only uses feed() plus unpack()/iteration (and RobustUnpacker creates a fresh Unpacker on each resync attempt), so this does not affect borg. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.4-maint #10469 +/- ##
=============================================
+ Coverage 82.09% 82.11% +0.01%
=============================================
Files 38 38
Lines 11479 11479
Branches 1808 1808
=============================================
+ Hits 9424 9426 +2
+ Misses 1469 1467 -2
Partials 586 586 ☔ View full report in Codecov by Harness. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow msgpack 1.2.3 (released 2026-09-29) in
pyproject.tomlandis_supported_msgpack().msgpack 1.2.3 fixes, in the C extension:
Unpacker.skip()Behaviour change checked: the C
Unpackernow raisesValueErrorwhen switching between unpack, skip, header readers orread_bytes()while an object is incomplete, and rejects re-entrant use. borg 1.4 only usesfeed()plusunpack()/iteration, andRobustUnpackercreates a freshUnpackerfor each resync attempt, so borg is not affected.Tested locally (macOS, Python 3.13, msgpack 1.2.3 C extension): full testsuite, 1389 passed, 368 skipped.
🤖 Generated with Claude Code