Commit 7e728f6
Allow the e2e suites to be run manually against master (#833)
The three e2e jobs are gated on `github.event.pull_request.labels`, which
is empty for a push. They therefore skip on every push to master as well
as on every unlabelled pull request, so nothing has run them on master
for some time.
That matters most just before a release, when we want to know that the
commit we are about to tag actually passes end to end. Until now the only
way to get an e2e run was to open a pull request and label it, which
tests a merge commit rather than master itself.
Adding `workflow_dispatch` gives a Run workflow button that runs all
three suites against any ref, including master. The label route is
unchanged for pull requests.
Two things stay as they are:
- The GKE cluster cleanup guard reads the same missing labels field, so
on a manual run it evaluates to true and the cluster is still deleted.
- The cluster name is derived from a timestamp, not the pull request, so
it is already safe outside a pull request context.
Verified by labelling this PR: all three e2e suites ran and passed via
the existing label route, confirming the added condition does not break
it.
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Richard Wall <richard.wall@cyberark.com>1 parent 2463606 commit 7e728f6
1 file changed
Lines changed: 7 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
6 | 10 | | |
7 | 11 | | |
8 | 12 | | |
| |||
80 | 84 | | |
81 | 85 | | |
82 | 86 | | |
83 | | - | |
| 87 | + | |
84 | 88 | | |
85 | 89 | | |
86 | 90 | | |
| |||
117 | 121 | | |
118 | 122 | | |
119 | 123 | | |
120 | | - | |
| 124 | + | |
121 | 125 | | |
122 | 126 | | |
123 | 127 | | |
| |||
151 | 155 | | |
152 | 156 | | |
153 | 157 | | |
154 | | - | |
| 158 | + | |
155 | 159 | | |
156 | 160 | | |
157 | 161 | | |
| |||
0 commit comments