Bump ActiveRocketPy to the v1.13 actuator hotfix - #114
Merged
Merged
Conversation
Picks up ARRC-Rocket/ActiveRocketPy#19 through its release in #23: the actuator argument checks survive `python -O`, a non-finite command is refused at the setter rather than reaching the integrator, `add_*_control` hands the controller the same sampling rate the actuator kept, and a range that is not a pair of numbers is refused. No score moves. Both shipped scenarios leave the three actuator time constants `null`, so the filter branch never runs, and their ranges are ordinary finite numbers. Both golden masters pass unchanged, the suite is 315 passed, and `uv lock --check` still resolves, so the lockfile needs no change. The setter now raising on a non-finite command is what #113 was about. The environment side of that lands with the action validation in fix/a-non-finite-action-is-not-a-command, so a competitor's NaN action keeps being dropped rather than becoming an exception. Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up ActiveRocketPy#19 through its release in #23, which is the order agreed on #61.
435f58d0to473447d5. The tree difference is four files, all of them the actuator work: the argument checks survivepython -O, a non-finite command is refused at the setter rather than reaching the integrator, eachadd_*_controlhands the controller the same sampling rate the actuator kept, and anactuator_rangethat is not a pair of numbers is refused rather than dropping a third value in silence.No score moves
Both shipped scenarios leave
gimbal_time_constant,roll_torque_time_constantandthrottle_time_constantatnull, so the branch #19 touches never runs, and their ranges are ordinary finite numbers.BPC_RUN_SLOW_TESTS=1uv lock --checkresolves, so no lockfile changeOne behaviour change to land alongside
The actuator setter now raises on a non-finite command. Without the environment side, a competitor's agent emitting NaN would lose its whole evaluation instead of the step, which is what #113 decided against.
That side is
fix/a-non-finite-action-is-not-a-command, which addscheck_actionand drops the unusable field rather than the run. It should go in with this, or immediately before it.