wallet: Privatize Core descriptor records - #64
Open
BenWestgate wants to merge 1 commit into
Open
BenWestgate wants to merge 1 commit into
BenWestgate wants to merge 1 commit into
Conversation
The package-level core_descriptors adapter exposes import-record construction that runtime callers no longer need. Bitcoin Core already owns public derivation, while private descriptor construction is only an implementation detail of the Core adapter. Remove the unused public-deriver protocol and branch, keep the record builder private, and make installed/public-API checks enforce that boundary. Internal tests and verification tools continue to exercise the same fixed descriptor templates and arbitrary account handling. Fixes #63
BenWestgate
added
area: api
ChatGPT Codex Connector
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
core_descriptorsfrom the supported package API;wallet.py;_core_descriptorsfor the Bitcoin Core adapter, tests, and repository tools;Why
Bitcoin Core already owns the EC-dependent public derivation path. Exposing descriptor import records as a package API duplicates that boundary and leaves an obsolete abstraction that external callers do not need. This keeps
master_xprvunchanged and preserves arbitrary--accountbehavior in the Core integration.Validation
python -O: 60 passed;compileallandgit diff --check: pass;<5200cap.The local system interpreter is Python 3.14 without the repository dev environment, so Ruff, mypy, and the legacy
bip32differential oracle are left to the normal GitHub matrix.Fixes #63.
AI assistance was used to implement and validate this user-authorized branch-to-branch contribution.