Skip to content

gui: Refresh empty wallets automatically - #66

Open
BenWestgate wants to merge 1 commit into
gui-reviewability-v1from
codex/gui-wallet-refresh-v1
Open

BenWestgate wants to merge 1 commit into
gui-reviewability-v1from
codex/gui-wallet-refresh-v1

Conversation

@BenWestgate

Copy link
Copy Markdown
Owner

Follow-up to #65.

Refresh the eligible Bitcoin Core wallet list once per second while the wallet chooser is visible, matching the CLI's waiting behavior. The selected wallet is preserved by exact name, and polling shares the existing serialized worker boundary so it cannot overlap an import or correction job.

The manual “Check again” action is removed; a wallet created in Bitcoin Core appears automatically. Polling pauses while the chooser is hidden and stops after it leaves the navigation stack.

Validation:

  • 974 tests pass normally
  • 974 tests pass under python -O
  • Ruff check and format pass
  • strict mypy passes for src/codex32 and src/codex32_gui
  • GTK/Xvfb walkthrough passes, including automatic refresh, exact-name selection preservation, and polling shutdown

Poll Bitcoin Core once per second while the wallet chooser is visible, matching the CLI's waiting behavior. Preserve the selected wallet by exact name and serialize polling with other background work so refreshes cannot overlap imports or correction.

The GTK walkthrough covers automatic appearance, selection preservation, removal of the manual refresh button, and stopping after navigation. Full normal and optimized suites, Ruff, strict mypy, and the walkthrough pass.
@BenWestgate BenWestgate added the gate: adversarial review Resolve, merge, or explicitly defer before the next full adversarial review. label Sep 29, 2026 — with ChatGPT Codex Connector

@BenWestgate BenWestgate left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI-generated review, posted at the maintainer's request.

Not ACKing 9b4066e: if the selected wallet disappears on refresh, target falls through to len(current) and silently activates Create a new wallet. Continue can then change the destination without an explicit user choice.

Copy link
Copy Markdown
Owner Author

Review note: the polling change does remove the standalone #65 Check again path that dropped restoring, so the stacked #65→#66 candidate fixes that reviewed bug. One separate item still needs maintainer disposition: this PR raises the GUI review budget from 2,000 to 2,050 logical lines. The explicit budget authorization on record is for the installed library (<5200), not for changing the separately enforced GUI cap. Prefer keeping the GUI under 2,000 if that can be done without a risky pre-release refactor; otherwise the 2,050 cap should be an explicit human review/approval rather than an incidental test change.

@BenWestgate BenWestgate added area: gui Graphical user interface behavior. area: wallet/core Wallet integration and Bitcoin Core boundaries. enhancement New feature or request labels Sep 29, 2026 — with ChatGPT Codex Connector

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: gui Graphical user interface behavior. area: wallet/core Wallet integration and Bitcoin Core boundaries. enhancement New feature or request gate: adversarial review Resolve, merge, or explicitly defer before the next full adversarial review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant