gui: Refresh empty wallets automatically - #66
BenWestgate wants to merge 1 commit into
Conversation
Poll Bitcoin Core once per second while the wallet chooser is visible, matching the CLI's waiting behavior. Preserve the selected wallet by exact name and serialize polling with other background work so refreshes cannot overlap imports or correction. The GTK walkthrough covers automatic appearance, selection preservation, removal of the manual refresh button, and stopping after navigation. Full normal and optimized suites, Ruff, strict mypy, and the walkthrough pass.
BenWestgate
left a comment
There was a problem hiding this comment.
AI-generated review, posted at the maintainer's request.
Not ACKing 9b4066e: if the selected wallet disappears on refresh, target falls through to len(current) and silently activates Create a new wallet. Continue can then change the destination without an explicit user choice.
|
Review note: the polling change does remove the standalone #65 |
Follow-up to #65.
Refresh the eligible Bitcoin Core wallet list once per second while the wallet chooser is visible, matching the CLI's waiting behavior. The selected wallet is preserved by exact name, and polling shares the existing serialized worker boundary so it cannot overlap an import or correction job.
The manual “Check again” action is removed; a wallet created in Bitcoin Core appears automatically. Polling pauses while the chooser is hidden and stops after it leaves the navigation stack.
Validation:
python -Osrc/codex32andsrc/codex32_gui