Add e2e tests for the Decodable Reader setup dialog (BL-16607) - #8396
Merged
Merged
Conversation
andrew-polk
commented
Sep 23, 2026
Contributor
Author
|
[Claude Opus 5.5 from Andrew Polk's machine during preflight] Consulted Devin up to |
andrew-polk
commented
Sep 24, 2026
Seven Playwright spec files (17 tests) drive the real Bloom through the React setup dialog: the Sample Texts listing and matching-words preview, what OK saves and Cancel discards, dropping an empty stage, removing and reordering stages, and coexisting with the legacy Levels dialog. They automate Notion test cases 444 and 472. Shared steps live in src/BloomE2E/helpers/readerSetup.ts. The only production change is six test hooks in the dialog's components. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
andrew-polk
force-pushed
the
readerSetupE2eTests
branch
from
September 24, 2026 04:38
a4efd85 to
0e52ef3
Compare
andrew-polk
marked this pull request as ready for review
September 24, 2026 04:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bloom production code changes
Test hooks only, no change in behavior, in
src/BloomBrowserUI/bookEdit/toolbox/readers/readerSetup/:SampleWordsTab.tsx: a test id on the typed-words box and on each Sample Texts file row, adata-valid-typeattribute on each row, and an id on the "no sample texts yet" message.MatchingWordsPanel.tsx: a test id on each matching-word chip.ReaderDialogPhaseSection.tsx: a test id on the Remove Stage button.Problem
The React Decodable Reader setup dialog (#8132) shipped with one end-to-end test, a happy-path journey. Its riskiest parts had no automated coverage: the Sample Texts listing and matching-words preview, which cross from the dialog into the toolbox frame; what OK saves and Cancel discards; and living alongside the Leveled Reader's legacy dialog.
What the PR does
Adds seven Playwright spec files (17 tests) that drive the real Bloom:
Shared steps live in
src/BloomE2E/helpers/readerSetup.ts. One limitation is recorded inAUTOMATION-DEBT.md: saving reader settings costs the next test in a file its shell document.Automates Notion test cases 444 (Sample Words From Sources) and 472 (Non-Alphabetic Letters Allowed).
Intermittent failures: in the first ~15 minutes after a fresh Bloom build, the coexist test failed several times: Set Up Levels was clicked and its dialog never opened. It has passed every run since, and the cause is not known.
Ref: https://issues.bloomlibrary.org/youtrack/issue/BL-16607
🤖 Generated with Claude Code
Devin review
This change is