basis - add collocated gradient to CeedBasis and cache its computation - #2045
Merged
Merged
Conversation
jeremylt
reviewed
Sep 21, 2026
jeremylt
left a comment
jeremylt
left a comment
Member
There was a problem hiding this comment.
Is there a way to mark that struct as nolint?
jeremylt
reviewed
Sep 21, 2026
- Rename `CeedBasisGetCollocatedGrad` to `CeedBasisGetCollocatedGrad1D` and change signature to take `const CeedScalar **` like other getters - Add `CeedBasisHasCollocatedGrad` to check whether collocated gradient is suppported for a `CeedBasis` - Update backends which either (a) computed the collo grad, or (b) precomputed and stored the collo grad, to use the caching `CeedBasisGetCollocatedGrad1D` function
zatkins-dev
force-pushed
the
zach/basis-collo-grad-interface
branch
from
September 21, 2026 15:29
3f00c44 to
a1d4d20
Compare
jeremylt
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
Additional
CeedBasisinterface cleanup and unified caching of objects used by multiple backends. Specifically:CeedBasisGetCollocatedGradtoCeedBasisGetCollocatedGrad1Dand change signature to takeconst CeedScalar **like other getters; the output array is now set to the internally cached collocated gradient matrix.CeedBasisHasCollocatedGradto check whether collocated gradient is suppported for aCeedBasisCeedBasisGetCollocatedGrad1DfunctionNote: Currently failing pedantic check due to empty struct, though it will no longer be empty after #2010. Not sure the best way to deal with that.
Describe the purpose of the PR here.
LLM/GenAI Disclosure:
None