Repository navigation
fix: properly resolve platform plugin file templates - #1905
Merged
Merged
Conversation
derklaro
added
v: 4.X
DasBabyPixel
reviewed
Oct 4, 2026
| try (var templateFileReader = templateFileResource.openReader(true)) { | ||
| return this.parser.parse(templateFileReader); | ||
| } | ||
| } catch (IOException _) { |
Contributor
There was a problem hiding this comment.
should probably log this or comment why it doesn't need to be logged
0utplay
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the template file resolution is trying to resolve a file within the project dir. This has a major flaw, which is that Gradle cache results can stay up-to-date even if the file was modified. Also, given that the current resolution depends on a hack, resolving the file is not guaranteed to succeed and there is no proper way to debug issues like this.
Modification
Add all resource source directories to the compiler sourcepath. This has the downside that resource modifications trigger full java source recompilation for modules and plugins, but resolution of the files is now working properly.
Result
Template files for module/plugin configurations are now resolved reliable and workaround-free.