fix(player): serialize audio worklet output lifecycle operations - #2911
Merged
Merged
Conversation
The audio worklet output finishes its audio graph setup asynchronously (worklet module load) while play/pause/destroy are synchronous. Pausing before the setup completed called stop() on a never-started source, and stale setup continuations started the source of a later play, leaving the output stalled. The audio graph operations of play, pause and destroy are now chained to run in the order of the calls. Each play buffers only the events received until its own worklet is created. Destroy cancels a pending worklet load wait so it is never delayed by a stalled load. Refs #2821
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
AI-authored disclosure (
alphatab-ai-authored-v1)Portions of this content were authored by an AI agent. The agent has read
AGENTS.md and the human submitter accepts responsibility for
compliance with the rules in that document.
Issues
Fixes #2821
Proposed changes
The audio worklet output finishes its audio graph setup asynchronously (worklet module load) while play/pause/destroy are synchronous. Pausing before the setup completed called stop() on a never-started source, and stale setup continuations started the source of a later play, leaving the output stalled.
The audio graph operations of play, pause and destroy are now chained to run in the order of the calls. Each play buffers only the events received until its own worklet is created. Destroy cancels a pending worklet load wait so it is never delayed by a stalled load.
Checklist
AI authorship disclosure
(
alphatab-ai-authored-v1) is present at the top of this body, and I havepersonally reviewed every change and can explain each one
Further details