Skip to content

fix(ci): parse clang-tidy analyzer warning suffix - #2499

Open
ankit25bcs10610 wants to merge 1 commit into
DeusData:mainfrom
ankit25bcs10610:fix/lint-mem-gate-warning-suffix
Open

ankit25bcs10610 wants to merge 1 commit into
DeusData:mainfrom
ankit25bcs10610:fix/lint-mem-gate-warning-suffix

Conversation

@ankit25bcs10610

Copy link
Copy Markdown

Summary

Closes #2442 (the clang-tidy diagnostic parsing part).

When WarningsAsErrors: '*' is enabled, clang-tidy renders analyzer diagnostics as:

[clang-analyzer-core.NullDereference,-warnings-as-errors]

The lint memory gate only accepted [check], so it silently discarded these findings and could report a clean gate. This change accepts the optional suffix while preserving the existing whitelist key (clang-analyzer-core.NullDereference).

Validation

  • tests/test_lint_mem_gate.sh
  • python3 -m py_compile scripts/lint-mem-gate.py
  • git diff --check

The regression test proves that a suffixed analyzer finding matches its normal whitelist entry and is counted as an argued finding.

Written with the assistance of an AI coding agent; the commit is DCO-signed by the submitting account.

Signed-off-by: Your GitHub Username <your_email@example.com>
@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown

Thanks for opening this — it has been seen, and it is queued.

This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence.

Current review status: working through a backlog. 0.9.1-rc.1 is out, so the release freeze that held reviews is over — but it left a large queue of open pull requests behind it, and we are reading through them oldest-first. The background is in discussion #1144.

What that means for this PR, concretely:

  • It will not be closed for inactivity. No stale bot touches pull requests here.
  • It may still sit a while before a human reads it. That is on us, not on you.
  • Older PRs are read first, so a recent one is not being skipped — it is behind a queue.

Things that will genuinely speed it up whenever review does happen:

  • Keep it rebased on main — the tree is moving quickly right now, and a conflicting branch cannot be reviewed as the diff you intended.
  • Get CI green, or say which failures you believe are pre-existing.
  • Keep the change to one claim. Bundled features and refactors get split before they get merged, which costs you a round trip.
  • Every commit needs a sign-off (git commit -s) — CI enforces DCO.

If this fixes a bug, a reproduction we can run is worth more than a description of the symptom.

Thanks for contributing, and sorry in advance for the wait.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lint-mem gate can't fail: CI analyses no file, and the gate drops every analyzer finding

1 participant