fix(platform-browser): skip close() on worker ports that do not implement it - #8636
Open
santiago-ramos-02 wants to merge 1 commit into
Open
santiago-ramos-02 wants to merge 1 commit into
santiago-ramos-02 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 3f4dda7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
santiago-ramos-02
requested a deployment
to
fork
September 30, 2026 19:22 — with
GitHub Actions
Waiting
santiago-ramos-02
requested a deployment
to
fork
September 30, 2026 19:22 — with
GitHub Actions
Waiting
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8635.
The per-port finalizer in
BrowserWorkerRunner.makecalledport.close()unconditionally. Bun's worker global implements the messaging surface used by the runner but notclose(), so the finalizer threwTypeError: port.close is not a functionwhen the runner shut down in a Bun worker. The owning parent still terminates the worker, so the finalizer now skipsclose()when the port does not have it.Testing
closes a port without a close methodtotest/BrowserWorkerRunner.test.ts. It fails onmainwithTypeError: port.close is not a functionand passes with this change.pnpm vitest run test/BrowserWorkerRunner.test.ts(3 passed),tsc -bfor@effect/platform-browser,oxlintanddprint checkon the touched files.🤖 Generated with Claude Code