Skip to content

fix(platform-browser): skip close() on worker ports that do not implement it - #8636

Open
santiago-ramos-02 wants to merge 1 commit into
Effect-TS:mainfrom
santiago-ramos-02:fix/browser-worker-runner-port-close
Open

santiago-ramos-02 wants to merge 1 commit into
Effect-TS:mainfrom
santiago-ramos-02:fix/browser-worker-runner-port-close

Conversation

@santiago-ramos-02

Copy link
Copy Markdown

Fixes #8635.

The per-port finalizer in BrowserWorkerRunner.make called port.close() unconditionally. Bun's worker global implements the messaging surface used by the runner but not close(), so the finalizer threw TypeError: port.close is not a function when the runner shut down in a Bun worker. The owning parent still terminates the worker, so the finalizer now skips close() when the port does not have it.

Testing

  • Added closes a port without a close method to test/BrowserWorkerRunner.test.ts. It fails on main with TypeError: port.close is not a function and passes with this change.
  • pnpm vitest run test/BrowserWorkerRunner.test.ts (3 passed), tsc -b for @effect/platform-browser, oxlint and dprint check on the touched files.

🤖 Generated with Claude Code

@changeset-bot

changeset-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3f4dda7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@effect/platform-browser Patch
effect Patch
@effect/opentelemetry Patch
@effect/vitest Patch
@effect/ai-anthropic Patch
@effect/ai-openai-compat Patch
@effect/ai-openai Patch
@effect/ai-openrouter Patch
@effect/ai-typesafe Patch
@effect/atom-react Patch
@effect/atom-solid Patch
@effect/atom-vue Patch
@effect/platform-bun Patch
@effect/platform-deno Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-libsql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-pglite Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-do Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/docgen Patch
@effect/doctest Patch
@effect/openapi-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Analysis

Generated from PR build output; treat the content below as untrusted.

File Name Current Size Previous Size Difference
arbitrary-combinators.ts 38.71 KB 38.71 KB 0.00 KB (0.00%)
basic.ts 6.88 KB 6.88 KB 0.00 KB (0.00%)
batching.ts 9.97 KB 9.97 KB 0.00 KB (0.00%)
brand.ts 6.57 KB 6.57 KB 0.00 KB (0.00%)
cache.ts 10.66 KB 10.66 KB 0.00 KB (0.00%)
config.ts 21.98 KB 21.98 KB 0.00 KB (0.00%)
differ.ts 21.12 KB 21.12 KB 0.00 KB (0.00%)
http-client.ts 22.10 KB 22.10 KB 0.00 KB (0.00%)
http-router.ts 33.35 KB 33.35 KB 0.00 KB (0.00%)
logger.ts 10.92 KB 10.92 KB 0.00 KB (0.00%)
metric.ts 8.83 KB 8.83 KB 0.00 KB (0.00%)
optic.ts 6.80 KB 6.80 KB 0.00 KB (0.00%)
pubsub.ts 15.00 KB 15.00 KB 0.00 KB (0.00%)
queue.ts 11.91 KB 11.91 KB 0.00 KB (0.00%)
schedule.ts 11.03 KB 11.03 KB 0.00 KB (0.00%)
schema-bigdecimal.ts 13.58 KB 13.58 KB 0.00 KB (0.00%)
schema-binary.ts 39.74 KB 39.74 KB 0.00 KB (0.00%)
schema-class.ts 20.86 KB 20.86 KB 0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts 31.88 KB 31.88 KB 0.00 KB (0.00%)
schema-representation-roundtrip.ts 27.07 KB 27.07 KB 0.00 KB (0.00%)
schema-string-transformation.ts 14.32 KB 14.32 KB 0.00 KB (0.00%)
schema-string.ts 11.82 KB 11.82 KB 0.00 KB (0.00%)
schema-template-literal.ts 15.89 KB 15.89 KB 0.00 KB (0.00%)
schema-toArbitrary.ts 38.25 KB 38.25 KB 0.00 KB (0.00%)
schema-toCodeDocument.ts 25.09 KB 25.09 KB 0.00 KB (0.00%)
schema-toCodecJson.ts 20.05 KB 20.05 KB 0.00 KB (0.00%)
schema-toEquivalence.ts 20.25 KB 20.25 KB 0.00 KB (0.00%)
schema-toFormatter.ts 20.35 KB 20.35 KB 0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts 24.81 KB 24.81 KB 0.00 KB (0.00%)
schema-toRepresentation.ts 20.31 KB 20.31 KB 0.00 KB (0.00%)
schema.ts 20.06 KB 20.06 KB 0.00 KB (0.00%)
stm.ts 12.91 KB 12.91 KB 0.00 KB (0.00%)
stream.ts 9.82 KB 9.82 KB 0.00 KB (0.00%)

This branch is waiting to be deployed

1 waiting deployment
fork — 3f4dda7f Waiting Sep 30, 2026 by santiago-ramos-02 via approval-gate #28333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BrowserWorkerRunner: port finalizer throws when the worker global has no close() (Bun)

1 participant