Repository navigation
C5: Rewrite guidance suite and repo content to v2 (Effect-first) - #37
Merged
Merged
Conversation
…; glossary v2 renames (issue #28)
…ools, Effect-first definition, exports["./server"] (issue #28)
…t intro, plugin-registered tools (issue #28)
…ct-first style (issue #28)
…nitions, plugins key, hook-family map, generation cache (issue #28)
…ts §5, ruleset permissions, no config.json (issue #28)
…g, ruleset permissions, hex-only color (issue #28)
…model selection, programmatic registration (issue #28)
…ools, JSON-Schema arguments, action table (issue #28)
…autoinvoke, skill-action permissions (issue #28)
…uth, disabled flag, split timeouts, codemode (issue #28)
…ts, ruleset permissions, plugin-registered tools (issue #28)
… conformant, new F items (Effect definition, permissions array, JSON-Schema args, entrypoint) (issue #28)
…equire verified-facts citations (issue #28)
…er placement, nullable exempt (review of #28)
…olerance, request.body mapping, self-contained tool snippet, schema-URL hedge (issue #28)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #28. Rewrites the guidance suite and repo content in place to v2 facts (Effect-first), every changed fact traced to the verified-facts record (
docs/reference/opencode-v2-facts.md).@opencode/plugin/effect,{ id, effect }), the pluralpluginsregistration key, permissions ruleset arrays, JSON-Schema tool arguments, v2 MCP shapes (snake_case oauth,disabled, split timeouts), v2 agent frontmatter mapping, and the hook-family migration map. The conformance checklist inverts D8 (thepluginsplural key is now conformant) and adds F1–F4: Effect plugin definition, permissions array, JSON-Schema tool arguments, mandatoryexports["./server"](facts §13.9/§14.6). Cache paths updated to the v2 npm generation cache. General Effect-TS teaching defers to the repo's effect-ts skill; v1 names appear only in explicit v1→v2 migration mappings — no v1 archive.tests/docs-fact-gate.ts+tests/docs-fact-gate.test.ts: fails on known-false v1 claims re-entering guidance or repo content and on API-teaching references lacking a verified-facts citation. Facts record §13 gains row 10 (legacy singularplugintolerance adjudicated as suite-level behavior, per §15's extend-§13 rule).Verification
bun test tests/docs-fact-gate.test.ts→ 3 pass, 0 fail (gate green oncb5c59e)bun run checkcleanbun testat the pre-existing win32 baseline only — 5 environment failures verified identical on base commit72bb363, tracked in Win32-only test failures: tarball path resolution and chmod-based removal-failure injection #36; ubuntu CI unaffectedOut of scope (per spec #23): templates (C6) and agent definitions (C7) untouched.
Review: two-axis pass (standards + spec) done during development; all hard findings fixed.