Encode collection wrapper element name via XmlNameProcessor - #918
Open
Sahana2524 wants to merge 2 commits into
Open
Sahana2524 wants to merge 2 commits into
Sahana2524 wants to merge 2 commits into
Conversation
Sahana2524
force-pushed
the
wrapper-name-encode
branch
from
September 27, 2026 15:27
2f112c2 to
98f21c1
Compare
🧪 Code Coverage Report
|
1 similar comment
🧪 Code Coverage Report
|
cowtowncoder
changed the title
XmlNameProcessor
🧪 Code Coverage Report
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collection wrapper element name skips the
XmlNameProcessorstartWrappedValue()writes the wrapper element straight to the Stax writer, so with a non-passthrough processor the wrapper name comes out verbatim while the wrapped item names (which go throughwriteName()->encodeContentName()) are encoded. Since the reader decodes every element name, a default wrappedListserialized withnewAlwaysOnBase64Processor()then throwsStreamReadExceptionon read (the raw wrapper name is not valid base64), and a wrapper name holding an XML-invalid character such as a space emits non-well-formed XML. Routing the wrapper name throughencodeContentName()first keeps it symmetric with the item names; passthrough output is unchanged.