Conversation
n-lark
added this pull request to stack #2258
October 1, 2026 13:47
n-lark
commented
Oct 1, 2026
| let storeEnabled = false | ||
| const trimCounts = {} | ||
| const TRIM_BATCH = 60 | ||
| let warned = false |
Contributor
Author
There was a problem hiding this comment.
Sooo warnOnce only warns on the first failure. After that, every store failure, from any widget, is silent until the next full deploy or restart. Could extend it to warn per type of failure, or every N failures. Lmk if we want that, can always iterate down the line.
3 of 14 tasks
cstns
approved these changes
Oct 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First layer of #2239. Before the store starts driving the dashboard, failures in it need to be visible: today every store write swallows its errors, so a store that stops accepting writes fails silently.
Test plan
global.dashboardStorestill warns onceRelated Issue(s)
Resolves #2267
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel