-
Notifications
You must be signed in to change notification settings - Fork 256
Figure.histogram: Add parameters to annote bars and deprecate parameter 'annotate' #4895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+85
−16
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2b54a3d
Figure.histogram: Add parameters to annote bars
seisman 5f527aa
Update histogram tutorial
seisman 148d411
Merge branch 'main' into histogram/annot
seisman 019baa5
Merge branch 'main' into histogram/annot
seisman 916f9f9
Merge branch 'main' into histogram/annot
seisman a2f815f
Apply batched suggestions from code review
seisman 47f0045
Apply suggestion from @yvonnefroehlich
seisman f9b6d8b
Apply suggestion from @yvonnefroehlich
seisman 3175552
Merge branch 'main' into histogram/annot
seisman 0394768
annot_position should be either start or end
seisman d469eb5
Fix doctest
seisman a915ea2
Merge branch 'main' into histogram/annot
seisman a8d46e8
Merge branch 'main' into histogram/annot
seisman 176cd18
Merge branch 'main' into histogram/annot
seisman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having
default = Noneand then giving a explicit default could be a bit confusing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this style is used in the whole documentation.
Nonemeans using the default value.