Skip to content

Limit embed endpoints to GET only - #14609

Merged
mattiagiupponi merged 1 commit into
masterfrom
embed_endpoint
Sep 17, 2026
Merged

mattiagiupponi merged 1 commit into
masterfrom
embed_endpoint

Conversation

@sijandh35

Copy link
Copy Markdown
Contributor

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Sep 17, 2026
@sijandh35
sijandh35 requested a review from giohappy September 17, 2026 14:57
@mattiagiupponi
mattiagiupponi merged commit 1e60dcf into master Sep 17, 2026
18 checks passed
@mattiagiupponi
mattiagiupponi deleted the embed_endpoint branch September 17, 2026 16:17
@github-actions

Copy link
Copy Markdown
Contributor

The backport to 5.0.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.0.x 5.0.x
# Navigate to the new working tree
cd .worktrees/backport-5.0.x
# Create a new branch
git switch --create backport-14609-to-5.0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1e60dcf8a94782b52522086f6134521202f09c84
# Push it to GitHub
git push --set-upstream origin backport-14609-to-5.0.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.0.x

Then, create a pull request where the base branch is 5.0.x and the compare/head branch is backport-14609-to-5.0.x.

mattiagiupponi pushed a commit that referenced this pull request Sep 18, 2026
(cherry picked from commit 1e60dcf)

Co-authored-by: Sijan Dhungana <sumoseason35@gmail.com>
mattiagiupponi pushed a commit that referenced this pull request Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 5.0.x backport 5.1.x cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants