Skip to content

feat: activate future snark feature by default - #3555

Draft
damrobi wants to merge 11 commits into
mainfrom
damrobi/msnark/2814-activate-future-snark-by-default
Draft

damrobi wants to merge 11 commits into
mainfrom
damrobi/msnark/2814-activate-future-snark-by-default

Conversation

@damrobi

@damrobi damrobi commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

Content

This PR includes an update to the bytes codecs of the STM crate and the activation of the future_snark feature by default across the library.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Comments

Issue(s)

Closes #2814

…tions

gated the from_hash_bytes function behind test flag and removed allow(dead_code)
gated the from_hash_bytes function behind test flag and removed allow(dead_code)
- ProjectivePoint
- PrimeOrderProjectivePoint
- BaseFieldElement
- ScalarFieldElement
and updated the impl_serde macro
- BlsSigningKey
- BlsVerificationKey
- BlsProofOfPossession
- BlsSignature
and updated the impl_serde macro
@damrobi damrobi self-assigned this Sep 21, 2026
@github-actions

Copy link
Copy Markdown

Test Results

     5 files  ±    0     221 suites  ±0   9h 57m 7s ⏱️ + 7h 58m 16s
 3 682 tests  -     3   3 682 ✅  -     3  0 💤 ±0  0 ❌ ±0 
14 263 runs  +2 431  14 263 ✅ +2 431  0 💤 ±0  0 ❌ ±0 

Results for commit becf964. ± Comparison against base commit 6c7862f.

This pull request removes 8 and adds 5 tests. Note that renamed tests count towards both.
mithril-aggregator ‑ tools::genesis::operations::tests::bootstrap_test_genesis_certificate_works
mithril-aggregator ‑ tools::genesis::operations::tests::export_sign_then_import_genesis_payload
mithril-common ‑ certificate_chain::certificate_verifier::tests::verify_certificate_chain_fails_when_adversarial_with_registered_signer_forgery_through_protocol_parameters
mithril-end-to-end ‑ mithril::genesis_keys::tests::legacy_keys_for_lagrange_without_the_snark_feature
mithril-stm ‑ proof_system::halo2_ivc_snark::proof::tests::slow::prove_bootstrap_produces_first_epoch_proof_and_rolling_state
mithril-stm ‑ proof_system::halo2_ivc_snark::proof::tests::slow::prove_same_epoch_produces_proof_without_rolling_state
mithril-stm ‑ proof_system::halo2_ivc_snark::prover_setup::tests::slow::ivc_setup_downsizes_keys_and_srs_to_the_circuit_degree
mithril-stm ‑ proof_system::halo2_ivc_snark::prover_setup::tests::slow::load_succeeds_with_unsafe_srs
mithril-client ‑ certificate_client::verify::tests::verification_key_formats::constructor_accepts_dual_verification_key_bundle
mithril-client ‑ certificate_client::verify::tests::verification_key_formats::verify_chain_succeeds_with_dual_bundle_on_pythagoras_chain
mithril-client ‑ certificate_client::verify::tests::verification_key_formats::verify_chain_succeeds_with_legacy_verification_key_on_lagrange_chain
mithril-end-to-end ‑ mithril::genesis_keys::tests::dual_keys_for_lagrange_on_nodes_accepting_them
mithril-end-to-end ‑ mithril::genesis_keys::tests::dual_keys_when_lagrange_is_the_next_era

This branch had an error being deployed

2 failed deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Activate future_snark feature by default

1 participant