[SDK-707] Replace request AsyncTask with SDK executor by franco-zalamena-iterable · Pull Request #1096 · Iterable/iterable-android-sdk

franco-zalamena-iterable · 2026-09-21T08:44:53Z

📝 Summary

Moves API request execution from AsyncTask to an SDK-owned serial dispatcher while preserving callback threading and existing retry behavior.

🎟️ Jira Ticket: SDK-707

📖 Description

This stacked PR builds on SDK-706 and:

Replaces IterableRequestTask AsyncTask execution with a package-private IterableRequestDispatcher.
Serializes online, offline, delayed, and JWT retry requests on the SDK-owned request executor.
Delivers API response callbacks on the main thread.
Preserves the existing Android JWT retry contract: retried requests retain the legacy callback but do not reattach modern callbacks or the offline processor marker.
Adds readable behavior-focused Kotlin tests and an inline dispatcher test harness so tests do not depend on timing.

🧪 How to test?

./gradlew --no-daemon :iterableapi:testDebugUnitTest :iterableapi-ui:testDebugUnitTest
./gradlew --no-daemon :iterableapi:checkstyle
Review IterableApiRequestExecutionTest, IterableRequestDispatcherTest, and IterableRequestTaskTest for the documented production request flow.

The standalone inbox-customization sample remains blocked by its pre-existing Kotlin 1.8 incompatibility with the data object declaration in iterableapi-ui.

🧾 Changelog

Updated the existing Unreleased executor entry to include API requests and API response callback threading.

📹 Loom recording if applicable

Not applicable.

🐞 Github Issues solved

None.

📚 Docs PR if applicable

No documentation PR required.

rtlsilva

The ticket says the full suite should contain no ShadowPausedAsyncTask references, but this head still has six references in BaseTest, IterableApiIntegrationTest, and IterableApiGetAndTrackDeepLinkTest.

Suggest removing the remaining shadow dependencies and synchronizing those tests through the new request seam or the appropriate executor/looper primitives.

rtlsilva · 2026-09-21T17:17:58Z

                healthMonitor,
                classification);
-        taskScheduler = new TaskScheduler(taskStorage, taskRunner);
+        taskScheduler = new TaskScheduler(taskStorage, taskRunner, requestDispatcher);


The dispatcher is passed to TaskScheduler, but stored requests do not use it: IterableTaskRunner still invokes IterableRequestTask.executeApiRequest() directly on its own HandlerThread. A persisted request can therefore overlap with or be overtaken by immediate requests running on IterableExecutors.serial(), so this PR's stated serialization of offline requests does not hold.

Suggest routing task-runner network execution through the same request queue and covering stored-versus-immediate ordering.

Stored requests now use an SDK dispatcher, but the shared-ordering part of this thread has regressed in b6d0d841: immediate requests in offline mode use requestDispatchers.online() (now an 8-thread pool) while stored tasks use the separate requestDispatchers.offline() lane, and the submission-order test was removed. These paths can overlap or overtake one another again, and the PR description still says these requests are serialized.

This also isn't quite the pre-migration behaviour: on master, offline-mode immediate requests went through AsyncTask.execute() (the serial executor), and only OnlineRequestProcessor used THREAD_POOL_EXECUTOR. Routing them to online() makes them concurrent with each other as well.

If matching pre-migration concurrency is the goal, suggest keeping offline-mode immediate requests serial, updating the PR contract, and adding coverage for the intended cross-lane behavior.
Otherwise, suggest keeping both paths on one ordered dispatcher.

franco-zalamena-iterable · 2026-09-23T12:18:26Z

Review feedback is addressed in ffe5431:

Restored IterableApiIntegrationTest to the production dispatcher.
Synchronized the callback-driven automatic push-registration test through the main looper.
Migrated IterableApiResponseTest to IterableRequestDispatcher; Android test sources compile.
Documented the inline request seam callback contract.
Routed persisted offline requests through the same serial dispatcher as immediate requests, with stored-versus-immediate ordering coverage and an in-flight guard.
Removed all ShadowPausedAsyncTask references from the suite.

Verification on this commit:

SDK-707 behavior and regression tests pass in the 764-test core run. The sole local failure is the pre-existing external-image IterableNotificationTest.testNotificationImage; 21 tests are skipped.
iterableapi-ui unit tests pass.
lintDebug, checkstyle, iterableapi-ui assembleDebug, app unit tests, and Android-test compilation pass.
The standalone sample reaches iterableapi-ui compilation and remains blocked by its existing Kotlin 1.8 versus data object language-version mismatch.

Requesting another review.

franco-zalamena-iterable · 2026-09-23T13:00:56Z

Updated SDK-707 after the stack rebase, preserving all prior review fixes and addressing the concurrency concern:

Ordinary online API requests use a bounded concurrent SDK pool.
Push requests stay on the dedicated serial push lane.
Offline immediate and persisted requests share a dedicated serial offline lane.
Deep-link work remains on its separate SDK-706 lane.
Callbacks remain on main, and retries retain the originating dispatcher.

New focused coverage proves that the client routes ordinary and push requests to the correct lanes, a blocked online request does not serialize a second online request, and blocked online work does not delay push work. The synchronization uses latches with no sleeps.

Verification:

Focused executor, request, retry, offline, and task-runner suites pass.
Full core run: 770 passed, 21 skipped; only the pre-existing external IterableNotificationTest.testNotificationImage failed.
UI unit tests pass.
Lint, Checkstyle, UI assemble, root app unit tests, and Android-test source compilation pass.
The standalone sample remains blocked by its existing Kotlin 1.8 versus data-object language-version mismatch.

CI is currently running on e697ce6. Ready for another review.

franco-zalamena-iterable · 2026-09-23T13:09:11Z

Follow-up from the first CI run: the new concurrency and routing tests passed. CI exposed a separate Mockito spy race in IterableFirebaseMessagingServiceTest, where a pending initialization callback could call getDebugMode while the test was stubbing getInAppManager. Commit 2f34558 now drains initialization callbacks before creating the spy and uses safe doReturn stubbing. The affected service tests and executor tests pass locally; replacement CI is running.

franco-zalamena-iterable · 2026-09-23T13:27:39Z

Final CI follow-up for 2f34558:

Check, changelog, Java analysis, CodeQL, BCIT, and instrumentation all pass.
The callback-driven Mockito race no longer appears.
The unit job ran 771 tests with only the repository-wide external IterableNotificationTest.testNotificationImage failure; all SDK-707 executor, routing, request, retry, offline, and service tests passed.

The branch is now waiting only on reviewer approval and the known external image-test failure.

rtlsilva

No new comments on this PR, but waiting for ancestor PRs #1093 and #1094 for a final review before approving.

jferrao-itrbl

Great work @franco-zalamena-iterable . LGTM.

It might be worth checking the failing test though it seems unrelated with these changes.

rtlsilva

Reopened a discussion, no other findings.

franco-zalamena-iterable requested a review from a team as a code owner September 21, 2026 08:44

franco-zalamena-iterable added this pull request to stack #1095 September 21, 2026 08:45

franco-zalamena-iterable requested a review from jferrao-itrbl September 21, 2026 10:26

jferrao-itrbl requested changes Sep 21, 2026

View reviewed changes

rtlsilva requested changes Sep 21, 2026

View reviewed changes

joaodordio requested review from jferrao-itrbl and rtlsilva September 23, 2026 10:23

franco-zalamena-iterable force-pushed the feature/sdk-707-request-executor branch from 419a140 to ffe5431 Compare September 23, 2026 12:16

franco-zalamena-iterable force-pushed the feature/sdk-707-request-executor branch from ffe5431 to e697ce6 Compare September 23, 2026 12:54

rtlsilva reviewed Sep 24, 2026

View reviewed changes

jferrao-itrbl approved these changes Sep 24, 2026

View reviewed changes

joaodordio requested a review from a team September 25, 2026 10:18

franco-zalamena-iterable force-pushed the feature/sdk-707-request-executor branch from 2f34558 to 7ca9382 Compare October 2, 2026 14:03

franco-zalamena-iterable added 6 commits October 6, 2026 09:54

[SDK-707] Replace request AsyncTask with SDK executor

1033bbc

[SDK-707] Address request executor review feedback

6353d6d

[SDK-707] Cover concurrent request execution

9d8a71a

[SDK-707] Stabilize callback-driven test setup

2066495

[SDK-707] Consolidate push request dispatch

83dca2a

[SDK-707] Preserve concurrent request behavior

b6d0d84

franco-zalamena-iterable force-pushed the feature/sdk-707-request-executor branch from 7ca9382 to b6d0d84 Compare October 6, 2026 09:00

rtlsilva requested changes Oct 6, 2026

View reviewed changes

Navigation Menu

Repository navigation

[SDK-707] Replace request AsyncTask with SDK executor - #1096

[SDK-707] Replace request AsyncTask with SDK executor#1096
franco-zalamena-iterable wants to merge 6 commits into
feature/sdk-706-deeplink-redirect-executorfrom
feature/sdk-707-request-executor

franco-zalamena-iterable commented Sep 21, 2026 •

edited by atlassian Bot

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rtlsilva left a comment

Uh oh!

rtlsilva Sep 21, 2026

Uh oh!

rtlsilva Oct 6, 2026

Uh oh!

franco-zalamena-iterable commented Sep 23, 2026

Uh oh!

franco-zalamena-iterable commented Sep 23, 2026

Uh oh!

franco-zalamena-iterable commented Sep 23, 2026

Uh oh!

franco-zalamena-iterable commented Sep 23, 2026

Uh oh!

rtlsilva left a comment

Uh oh!

jferrao-itrbl left a comment

Uh oh!

rtlsilva left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

franco-zalamena-iterable commented Sep 21, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Summary

🎟️ Jira Ticket: SDK-707

📖 Description

🧪 How to test?

🧾 Changelog

📹 Loom recording if applicable

🐞 Github Issues solved

📚 Docs PR if applicable

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rtlsilva left a comment

Choose a reason for hiding this comment

Uh oh!

rtlsilva Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

rtlsilva Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

franco-zalamena-iterable commented Sep 23, 2026

Uh oh!

franco-zalamena-iterable commented Sep 23, 2026

Uh oh!

franco-zalamena-iterable commented Sep 23, 2026

Uh oh!

franco-zalamena-iterable commented Sep 23, 2026

Uh oh!

rtlsilva left a comment

Choose a reason for hiding this comment

Uh oh!

jferrao-itrbl left a comment

Choose a reason for hiding this comment

Uh oh!

rtlsilva left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

franco-zalamena-iterable commented Sep 21, 2026 •

edited by atlassian Bot

Loading