-
Notifications
You must be signed in to change notification settings - Fork 145
Update shared SQL database page for PostgreSQL-only live sync #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
koppor
wants to merge
6
commits into
main
Choose a base branch
from
sqldatabase-postgres
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
845b271
Update shared SQL database page: PostgreSQL only, live sync, automati…
koppor f4c312f
SSL section: certificates come from JabRef preferences, keystore removed
koppor 89dbd74
Use SSL encrypts without server authentication (psql parity)
koppor a61d3c5
Describe the deletion notification replacing the dialog
koppor 94f162a
Remove screenshot of the removed deleted-entry dialog
koppor 60ebd3c
Describe pasting a connection URL in the shared database dialog (#670)
koppor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Migration support is overstated
🐞 Bug≡ CorrectnessAgent Prompt
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation toolsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qodo can you verify wiht jabref's main repo again? Did we really remove the old schema? Probably we did already in 5.15?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can’t verify the current main-repo implementation from this thread alone. However, even if the legacy schema was removed in 5.15, the documentation still claims migration for any older JabRef database.
Please confirm the migration code’s supported schema/version range and whether pre-3.6 tables are handled. If they are not, the sentence needs an explicit cutoff and a link to the manual export/import procedure; if they are, the migration page should be updated to reflect that pre-3.6 databases are now supported.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qodo Check the source code https://github.com/JabRef/jabref