host/limine: Report failures saving uninstall data - #658
Closed
pro-utkarshM wants to merge 1 commit into
Closed
pro-utkarshM wants to merge 1 commit into
pro-utkarshM wants to merge 1 commit into
Conversation
Assisted-by: Codex:gpt-6-astra Signed-off-by: Utkarsh Maurya <projects.utkarshMaurya@gmail.com>
Author
|
Superseded by cec5802. The upstream fix also rolls back the installation when saving uninstall data fails and delays the success message, avoiding a retry recording installed sectors as the original recovery data. Closing this PR to avoid duplicating the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
--uninstall-data-filecannot be saved,bios-installprints an error but exits successfully because it ignoresstore_uninstall_data()'s return value. Propagate that failure to the process exit status while retaining the existing cleanup and completed installation.Validation: reproduced backup-open and backup-write failures with and without
--quiet. All eight regression cases pass with the fix, including normal installation and a successful backup/uninstall roundtrip that restores the original image byte-for-byte. The standalone script is in the linked issue. The C99 host build and full LLVM build (./bootstrap,./configure --enable-werror --enable-all,make all) passed with warnings treated as errors.Fixes #657.