menu: Fix hang when pressing a key during quiet boot - #664
Open
hotline1337 wants to merge 1 commit into
Open
hotline1337 wants to merge 1 commit into
hotline1337 wants to merge 1 commit into
Conversation
Signed-off-by: hotline1337 <denuvo@tuta.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
quietmode is active, the terminal is not fully initialized. If the autoboot timeout is interrupted by an unhandled key (or a stray keystroke from the firmware), the previous logic disabled thequietflag but passed the key directly into the inputswitch.Because unhandled keys fall through to the wait loop without triggering a screen refresh, Limine would hang on the firmware vendor logo indefinitely, waiting for further input without any visual feedback. This also affected setups with
TIMEOUT=noandquiet: yes, where the timeout loop is skipped entirely.This PR moves the
quietwake-up logic to thetimeout_abortedlabel and forces an unconditionalgoto refresh. This guarantees that the first keystroke (or firmware event) cleanly initializes the terminal and draws the menu before waiting for further input.