feat(web): rebuild the releases list around deploys - #1089
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (14)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Maple reviewNothing to review Warning This review ended early; what follows is what it established. The review could not be completed: no changed-file diff was read, only surrounding repository context, so nothing about this pull request can be vouched for. What was checked
|
|
Note A newer push replaced |
Maple reviewConfidence 4/5 · likely safe to merge Rebuilds the releases list around deploys: a "Live now" strip with sibling-behind detection, before→after error rate and p95 for the worst service, and an Issues column fed by a new additive
What was checked
|
- A "Live now" strip shows the version each service serves in the latest bucket. A service is marked behind when newer releases reached the services it usually ships with but not it; independently deployed services never are. - Error rate and p95 read before -> after against the replaced version, for the worst service of the release (flagged first, then largest error jump). - A new Issues column counts issues first seen or regressed while each release was the newest on its service. - The Traffic column is gone, and a release on more than three services reads as a count that names only the flagged ones. The issue counts come from a new introduced_after filter on the v2 error issue list: first_seen_at or last_regressed_at at or after the given instant.
Rendering against real deploys showed every service marked "1 behind" while a new push was still rolling out on its first three services. A newer release now counts only once some sibling is serving it. Also: long commit subjects stretched the release column past the card (it now truncates), and the worst-service dot beside the error rate rendered zero-wide inside a plain inline span.
9679739 to
007a1b7
Compare
|
Note Maple is reviewing this pull request at |
Stack 2/4. Based on #1087.
What
API
GET /v2/error_issuesgains an additiveintroduced_afterfilter:first_seen_at >= X OR last_regressed_at >= X. The list page makes one request per window (limit 100) and attributes issues client-side. If the window has more than 100 matching issues, the page shows a note.Tests
release-model.test.ts:releaseHeadline,attributeIssues, andliveVersions(behind detection plus the independently-deployed case)ErrorIssueReadModelsService.test.ts: the new filter keeps fresh and regressed issues and drops ongoing onesNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.