Shell_NotifyIcon update - #2129
Nikita Leontiev (nikita-leontiev) wants to merge 1 commit into
Conversation
|
Nikita Leontiev (@nikita-leontiev) : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
John Kennedy (GrantMeStrength)
left a comment
John Kennedy (GrantMeStrength)
left a comment
There was a problem hiding this comment.
The Windows 10/11 balloon behavior note is a welcome addition — thank you! However, the PR also removes the descriptive text for NIM_ADD, NIM_DELETE, and NIM_MODIFY. Those descriptions explain what each message value does and are important reference content. Please keep those parameter descriptions and add the new Windows 10/11 behavior note in a separate Remarks section rather than replacing the existing content.
W article contains two copies of NIM_ADD/NIM_DELETE/NIM_MODIFY/NIM_SETFOCUS/NIM_SETVERSION info. |
|
Copilot /review |
John Kennedy (GrantMeStrength)
left a comment
John Kennedy (GrantMeStrength)
left a comment
There was a problem hiding this comment.
Review: Approve with Notes
Good additions: Win10/11 notification behavior notes and the "bannner" → "banner" typo fix are welcome.
Concern: The PR removes detailed NIM_ADD/DELETE/MODIFY/SETFOCUS/SETVERSION parameter descriptions. If this information exists in the NOTIFYICONDATA structure docs, the removal is acceptable (avoids duplication). If not, it should be retained here. Please confirm these descriptions exist elsewhere before merging.
John Kennedy (GrantMeStrength)
assigned
John Kennedy (GrantMeStrength) and unassigned
Jim Walker (jwmsft)
|
Nikita Leontiev (@nikita-leontiev) : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. Jim Walker (@jwmsft) |
1 similar comment
|
Nikita Leontiev (@nikita-leontiev) : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. Jim Walker (@jwmsft) |
|
Nikita Leontiev (@nikita-leontiev) You're right — I confirmed the W version had duplicate NIM_* descriptions that already exist in the parameters table above. Removing the duplicates is correct. Also good catch on the "bannner" typo fix and the Windows 10/11 notification behavior addition to the A version. Approving. |
John Kennedy (GrantMeStrength)
left a comment
John Kennedy (GrantMeStrength)
left a comment
There was a problem hiding this comment.
Verified: duplicate NIM_* content removal is correct, typo fix good, and Win10/11 behavior note is a useful addition.
3 participants
Sync A and W articles. Typo fix.