wuapi: IUpdate: setter and getter param and retval info, slight corrections - #2194
Open
Ondřej Hošek (RavuAlHemio) wants to merge 6 commits into
Open
Ondřej Hošek (RavuAlHemio) wants to merge 6 commits into
Ondřej Hošek (RavuAlHemio) wants to merge 6 commits into
Conversation
Link to the relevant data type if an article exists; for data types mostly used in conjunction with VARIANT, link to VARIANT under "see also" instead. Also link to SysFreeString for BSTR values. The most direct benefit is the link to enum types like DeploymentAction or DownloadPriority.
Since AcceptEula is an action that can only be taken in one direction, it makes sense for it to be its own method instead of an EulaAccepted setter, but the two should still be cross-linked.
|
Ondřej Hošek (@RavuAlHemio) : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
John Kennedy (GrantMeStrength)
approved these changes
Jul 17, 2026
John Kennedy (GrantMeStrength)
left a comment
John Kennedy (GrantMeStrength)
left a comment
Contributor
There was a problem hiding this comment.
LGTM — accurate technical correction. Approved.
Contributor
|
Copilot /review |
John Kennedy (GrantMeStrength)
approved these changes
Jul 17, 2026
John Kennedy (GrantMeStrength)
left a comment
John Kennedy (GrantMeStrength)
left a comment
Contributor
There was a problem hiding this comment.
Reviewed ✅ — Documentation improvement looks good.
John Kennedy (GrantMeStrength)
assigned
John Kennedy (GrantMeStrength) and unassigned
drew batchelor (drewbatgit)
|
Ondřej Hošek (@RavuAlHemio) : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. drew batchelor (@drewbatgit) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope that the commit messages shed some light on my reasoning.
My primary concern was linking from a getter such as
IUpdate::get_DownloadPriorityto its enum type (DownloadPriorityin this case), since I sorely missed these when navigating the Windows Update API docs, but I made a few more changes.