Conversation
Signed-off-by: Hersh Godse <hersh@trajectory.ai>
hershg
force-pushed
the
codex/glm53-matched-20260916-01a0a846
branch
from
September 17, 2026 04:50
37d8217 to
e28e6e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Restore the saved Megatron scheduler counter when loading a checkpoint into an already-used worker. Core loads progress by adding the saved step count; reset the existing counter first so repeated restores do not accumulate steps.
The runtime change is two lines. A regression exercises the production loader with the real Core scheduler, advances it past the saved state, and restores twice. The equipped Megatron CI lane runs that test.
Validation
1 passed. Ruff, Black, secret checks, and independent source review passed. The production fix and test match the deployed GLM image source
6538c46a; this PR makes no GLM GPU qualification claim.