Add court-supervision childcare eligibility in ME, NC, VA, VT, and WA - #9554
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9554 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 6 +2
Lines 76 93 +17
Branches 2 0 -2
=========================================
+ Hits 76 93 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
… ME, NC, VA and VT Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
60f9b8d to
2247dbb
Compare
…s and tidy tests - Note in the five reused age parameters that the court-supervision route shares the special-needs ceiling, citing each state's rule and its CCDF Plan 2.2.1(c) election. - Correct the Virginia citation to 8VAC20-790-20(A)(1). - Retype the changelog fragment as "added" since the PR introduces the is_under_court_supervision input. - Drop is_disabled output assertions that only echoed an input default. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…into fix-court-supervision-national-9055
Program ReviewPR #9554 adds a person-level input, Source Documents
Critical (Must Fix)None. In all five states, the governing text puts court supervision in the same age clause as incapacity or special needs, so reusing the existing ceiling matches the law. Every ceiling, boundary test and effective date was checked against the source. The three effective-date concerns were cleared (see PDF Audit Summary). Should AddressParameter paths below are relative to
Suggestions
Sibling PRs in the #9055 series
Pre-existing issues (out of scope)
PDF Audit Summary
Validation Summary
Review Severity: COMMENTThere are no critical issues. The five eligibility changes match current law, including values, boundaries and effective dates. The Should Address items cover parameter metadata, one wrong page anchor and test gaps. None of them changes model output. Next StepsTo auto-fix issues: |
DTrim99
left a comment
There was a problem hiding this comment.
Requesting changes per the program review above (#9554 (comment)). There are no critical findings: all five states' routes match current law, including values, boundaries and effective dates. There are 6 should-address items:
- the NC/VA/VT/WA ceiling descriptions and labels don't mention court supervision;
- the VA Guidance Manual anchor points to #page=58, but the section is on #page=52;
- the NC references are incomplete;
- no test covers where the new route differs from the disabled route (NC 133% vs 200% FPL; VT service need);
- two WA tests don't check what their names say;
- no state tests court supervision combined with disability, or a court-supervised child under 13.
…n route divergences - NC, VA, VT and WA age parameters name special needs and court supervision in their descriptions and labels; CCDF Plan 2.2.1(c) elections, the NC manual and older plan, Maine's 2019 rule and Vermont's 2024 memo are references rather than comments. - Virginia cites Guidance Manual 3.3 G on page 52; Maine and Washington cite the clauses implemented. - Tests pin the NC 133% vs 200% FPL entry split and the VT service-need rule, replace WA's input-override activity case, assert the WA rate cap, and add court-plus-disability, under-13 and gate cases per state. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Program Review — Round 2This re-review covers PR #9554 at head Paths are relative to Round-1 items
The author disputed no item. Shared-file consistency
New issuesCriticalNone. Should addressNone. Suggestions
Value auditNo parameter value or effective date changed between round 1 and CI37 of 37 checks pass at Branch statusThe branch is 5 commits ahead of and 3 behind main ( Review severity: APPROVEAll 6 round-1 should-address items are resolved, the new commit changes no formula, value or date, CI passes in full, and the only open items are 7 optional suggestions plus 2 optional round-1 carry-overs. |
DTrim99
left a comment
There was a problem hiding this comment.
Approving per the round-2 review (#9554 (comment)). All 6 round-1 should-address items are resolved:
- the ceiling descriptions and labels now name court supervision;
- Virginia now cites Guidance Manual §3.3 G on #page=52, and the North Carolina references are restored;
- new tests pin the NC 133% vs 200% FPL split and the VT service-need rule;
- the WA tests are fixed;
- court-supervision × disability and under-13 cases are added.
Formula logic is unchanged, all 50 round-1 values still hold, the shared is_under_court_supervision files are byte-identical to main, and all 37 checks pass. The remaining suggestions (a VT plan anchor, a few description tweaks, an unused WA input) are optional.
Children under court supervision can qualify for child-care assistance after the ordinary age cutoff in Maine, North Carolina, Virginia, Vermont, and Washington. Add that missing route using
is_under_court_supervision: under 18 in NC/VA and under 19 in ME/VT/WA. Keep income, activity, immigration, dependency, and payment rules intact; court status does not set disability status or grant disability-based supplements.Authorities: Maine CCAP rule §§1,2, NC manual Chapter 4 IX, 8VAC20-790-20, Vermont CCFAP rule I.B.6, and RCW 43.216.802(2)(a)(ii). Existing age variables and historical thresholds are retained; birthday and renewal-date continuity are not newly modeled.
Validation: CI runs the affected-program YAML tests, including the court-supervision regressions (mixed-household, waiver, and a full-pipeline benefit case per state); no local runs.
make formatpassed. Partner tests were not changed. The reused age parameters now name both routes in their descriptions and labels and cite each state's approved CCDF Plan 2.2.1(c) election (ME/VT/WA 18.00, NC/VA 17.00) as references. Tests pin where the court route deliberately differs from the disability route (NC keeps the 133% school-age entry rate; VT's child special-health-need service need does not apply) and cover court supervision combined with disability and below age 13.Related to #9055. Separate from #9543 and #9547. Includes the identical shared input and its two tests so it can merge independently. Nationwide follow-up continues; this PR does not close the issue.