Skip to content

Fix Hawaii itemized income and sales tax deduction limits - #9597

Open
PavelMakarchuk wants to merge 2 commits into
mainfrom
codex/hi-salt-income-limit
Open

PavelMakarchuk wants to merge 2 commits into
mainfrom
codex/hi-salt-income-limit

Conversation

@PavelMakarchuk

@PavelMakarchuk PavelMakarchuk commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #9327.

Apply Hawaii's federal AGI limits to itemized income or sales taxes: $100,000 single/separate, $150,000 head of household, and $200,000 joint/surviving spouse. Eligibility ends at equality; real estate taxes remain deductible.

The parameter covers 2021 onward, consistent with existing Hawaii parameters. Sources: HRS 235-2.4(k)(2), 2021 instructions, and 2025 instructions.

Validation on 51741ec:

  • All 458 Hawaii baseline tests passed through the actual PolicyEngine test runner, including 25 new cases covering boundaries, years, federal versus Hawaii AGI, income/sales election, local sales tax, spouse property-tax aggregation, and downstream deductions/standard-deduction fallback.
  • Fixed initial fixture failures by explicitly setting local sales tax; omitted inputs otherwise invoke the existing modeled local sales tax.
  • Complete review-program workflow plus incremental review: no unresolved correctness findings; official PDFs and cited pages verified.
  • make format and git diff --check passed. Broader GitHub CI remains pending.

Local validation used the existing environment with the compatible spm-calculator 1.0.0.post1 wheel unpacked to a temporary PYTHONPATH directory; the shared environment was not modified.

@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (909176a) to head (51741ec).
⚠️ Report is 37 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #9597   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         1    -3     
  Lines           76        17   -59     
  Branches         2         0    -2     
=========================================
- Hits            76        17   -59     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PavelMakarchuk

Copy link
Copy Markdown
Collaborator Author

Program Review — incremental

Source Documents

Findings

  • C1 — RESOLVED: All three failed fixtures now explicitly set local sales tax to zero. The real engine passes all Hawaii baseline tests, confirming the correction.
  • A1 — RESOLVED: Added income/sales-tax election cases with nonzero local taxes, property-tax preservation, deduction aggregation, standard-deduction fallback and taxable-income assertions. Arithmetic independently checked and tests passed.
  • No critical or substantive findings remain. Optional zero-tax/mixed-status cases and test naming conventions remain minor suggestions (S1/S2).

Validation

  • Real PolicyEngine test runner: 458 passed, 1 warning across the complete Hawaii baseline suite (29.75 seconds).
  • Used the existing environment plus temporary unpacked spm-calculator==1.0.0.post1, within the project dependency range; no shared environment modification.
  • GitHub CI remains pending on run 36035207024. Local passing tests are not a claim that CI passed.
  • Original legal/PDF review: 10 filing-status value checks, zero mismatches; both added page references verified. Ninety pages rendered in the full review; cached evidence reused for this test-only update. Two review agents; no additional page rendering.

Review Severity: APPROVE

Ready for Ziming’s review. CI must finish before considering merge; no merge performed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hawaii itemized state-tax deduction ignores the federal-AGI disallowance threshold

1 participant