Fix Windows test execution and WebSocket cleanup - #1610
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No blocking issues were identified.
Pull request overview
Updates the Windows workflow so setup and npm test run within the retry action.
Changes:
- Chains environment setup and tests in one
cmdinvocation. - Uses
callfor batch setup and npm commands.
File summaries
| File | Description |
|---|---|
.github/workflows/windows-build-and-test.yml |
Runs Windows setup and tests inside the retry action. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
Concurrent closure during an in-flight failed handshake can still leave the underlying socket unclosed.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
| } | ||
| try { | ||
| ws.close(); | ||
| if (this._openFailed) onClose(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #1611