Skip to content

Fix Windows test execution and WebSocket cleanup - #1610

Merged
minggangw merged 3 commits into
RobotWebTools:developfrom
minggangw:fix-windows-workflow
Sep 18, 2026
Merged

minggangw merged 3 commits into
RobotWebTools:developfrom
minggangw:fix-windows-workflow

Conversation

@minggangw

@minggangw minggangw commented Sep 18, 2026 •

Copy link
Copy Markdown
Member
  • Run Windows setup and npm test as a single cmd command chain, propagating failures to the retry action.
  • Prevent close() from hanging after failed WebSocket handshakes that emit no close event on Node 22.
  • Clean up WebSocket links when close() races a pending connection attempt that fails.
  • Add regression coverage for HTTP-derived and explicit WebSocket connections, idempotent cleanup, concurrent closure, and successful retries.

Fix: #1611

Copilot AI lite review requested due to automatic review settings September 18, 2026 03:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No blocking issues were identified.

Pull request overview

Updates the Windows workflow so setup and npm test run within the retry action.

Changes:

  • Chains environment setup and tests in one cmd invocation.
  • Uses call for batch setup and npm commands.
File summaries
File Description
.github/workflows/windows-build-and-test.yml Runs Windows setup and tests inside the retry action.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@coveralls

coveralls commented Sep 18, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 90.955% (-0.001%) from 90.956% — minggangw:fix-windows-workflow into RobotWebTools:develop

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Concurrent closure during an in-flight failed handshake can still leave the underlying socket unclosed.

Get a fresh assessment by requesting another Copilot review.

Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread web/client.js
}
try {
ws.close();
if (this._openFailed) onClose();
@minggangw minggangw changed the title Ensure Windows tests execute inside the retry action Fix Windows test execution and WebSocket cleanup Sep 18, 2026
@minggangw
minggangw merged commit a66e983 into RobotWebTools:develop Sep 18, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix timeout failure with Nodejs 22 + Windows

3 participants