fix(notifications): read gh token param in PR notifier

[lelia]

What

The GitHub PR notifier resolved its credential from a token key:

self.token = self.config.get('token') or get_github_token()

The notifier parameter is declared as github_token in notifications.yaml, and that is the key the notification manager resolves dashboard configuration and the GITHUB_TOKEN environment variable into, so self.config.get('token') was always None.

Effect

A token set through dashboard config enabled the notifier (manager.py checks app_config.get('github_token') when deciding whether to load it) but the value never reached the GitHub API call. The notifier loaded, then returned at the if not self.token guard in _send_pr_comment, logging no GitHub token available and posting nothing.

Runs that configure the token through the environment were unaffected, because the notifier fell back to reading GITHUB_TOKEN directly.

Change

Look up github_token first, then token, then the environment. Keeping token means callers that construct the notifier directly are unaffected.

Precedence now matches the manager's documented parameter resolution (app_config over env var) and the pattern the other notifiers already follow — SlackNotifier reads slack_webhook_url, its own parameter name.

Tests

tests/test_github_pr_notifier_params.py, mirroring test_slack_notifier_params.py: direct construction and the manager flow, each covering params, environment fallback, and precedence, plus the legacy token key. Four of the eight fail without the change.

---

Note

Medium Risk
Changes how the GitHub PR notifier resolves API credentials; behavior shifts for dashboard-configured tokens while env and legacy token paths stay supported and are covered by new tests.

Overview
Fixes GitHub PR comments silently failing when the token is supplied through Socket dashboard / app_config as github_token. The notifier now resolves self.token from github_token first, then the legacy token key, then get_github_token() — matching notifications.yaml and the same pattern as SlackNotifier.

Dashboard-configured tokens previously enabled the notifier in NotificationManager but never reached the API, so runs logged no GitHub token available and posted nothing; GITHUB_TOKEN-only setups were unaffected.

Adds tests/test_github_pr_notifier_params.py (direct construction and manager load: params, env fallback, precedence, legacy key) and an [Unreleased] Fixed entry in CHANGELOG.md.

^{Reviewed by Cursor Bugbot for commit 1ec5579. Configure here.}

[lelia]

bugbot run

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 1ec5579. Configure here.}