Conversation
EvanHahn
added this pull request to stack #30836
September 16, 2026 20:31
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Contributor
|
It looks like this PR contains a migration 👀 General requirements
Schema changes
Data changes
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run ghost:test:ci:e2e |
❌ Failed | 4m 2s | View ↗ |
nx run ghost:test:e2e |
❌ Failed | 2m 55s | View ↗ |
nx run-many -t test:types -p ghost |
❌ Failed | 3s | View ↗ |
nx run ghost:test:legacy |
✅ Succeeded | 2m 29s | View ↗ |
nx run-many -t test:unit -p ghost |
✅ Succeeded | 30s | View ↗ |
nx run ghost-monorepo:lint:boundaries |
✅ Succeeded | 22s | View ↗ |
nx run-many -t lint -p ghost,ghost-monorepo |
✅ Succeeded | 21s | View ↗ |
nx run @tryghost/admin:build |
✅ Succeeded | 6s | View ↗ |
Additional runs (2) |
✅ Succeeded | ... | View ↗ |
💡 Dealing with memory or CPU issues? See memory and CPU details with the resource usage add-on ↗.
☁️ Nx Cloud last updated this comment at 2026-09-16 21:14:38 UTC
closes https://linear.app/ghost/issue/NY-1617 New migration that: - creates `automations.trigger_tier_scope` column with backfill - creates the `automation_trigger_tiers` table I considered adding a `trigger_type` column, but all automations are still something like "member signed up", so I don't think it's worth adding that column now. Easy to add in the future. Also requires us to insert this new data for new automations created with the legacy automated emails endpoint.
EvanHahn
force-pushed
the
evanhahn-ny-1617-add-migration-to-store-trigger-data-on-automations
branch
from
September 16, 2026 21:08
38c6b5b to
87872b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

closes https://linear.app/ghost/issue/NY-1617
New migration that:
automations.trigger_tier_scopecolumn with backfillautomation_trigger_tierstableI considered adding a
trigger_typecolumn, but all automations are still something like "member signed up", so I don't think it's worth adding that column now. Easy to add in the future.Also requires us to insert this new data for new automations created with the legacy automated emails endpoint.