Candidate CandID Patch Fix - #11168
Open
lapadulamichael wants to merge 2 commits into
Open
lapadulamichael wants to merge 2 commits into
lapadulamichael wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR fixes
candidate.CandIDstill being a signed int after running the upgrade patch. This was causing newly generated CandIDs to sometimes be out of range.This is because the change to candidate.CandID's type being
int(10) unsignedwas done only in the schema and not included in theSQL/Archive/27.0/2025-02-05-Change-Candid-FK-To-ID.sqlpatch.I added this to the archived patch and the release patch :