Update dependencies and drop obsolete json pin - #745
Merged
Merged
Conversation
Rails 8.1.4 is out and includes the ActiveSupport::JSON.decode fix for json 3.0 (rails/rails#58601), so the `json < 3.0` pin and its dependabot ignore rule are no longer needed. The pin was only ever needed for the root Gemfile, which targets Rails 8.1; the gemfiles/* Gemfiles never declared json. Also updates bundler to 4.0.22 and refreshes the transitive dependencies across all Gemfiles.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #745 +/- ##
=======================================
Coverage 94.33% 94.33%
=======================================
Files 17 17
Lines 459 459
=======================================
Hits 433 433
Misses 26 26 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the lockfiles and removes the now-obsolete
json < 3.0pin.This update was produced automatically by AI.
Dependency updates
All of these were verified to support Ruby >= 3.2, which is this gem's
required_ruby_versionfloor and the lowest Ruby in the CI matrix. Thelockfiles were regenerated on Ruby 3.2.11 to keep them valid for every
supported Ruby version.
Dropping the
jsonpinThe previous run pinned
json < 3.0because Rails 8.1 passed a positionaloptions hash to
JSON.parsefromActiveSupport::JSON.decode, which json3.0 rejects (rails/rails#58601).
That fix shipped in Rails 8.1.4, so the pin and its matching dependabot
ignorerule are no longer needed.jsonnow resolves to 3.0.2.The pin only ever existed in the root
Gemfile(which targets Rails 8.1);the
gemfiles/*Gemfiles never declaredjsonand are unaffected.Test plan
bundle exec rspec— 140 examples, 0 failuresbundle exec rubocop— 57 files inspected, no offenses detectedFull CI matrix (Ruby 3.2–4.0 × Rails 7.0–8.1) will run on this PR.