Skip to content

feat(shareddoc): bump da-parser to 2.2.0 for link-img support #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shsteimer wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −0
Draft

feat(shareddoc): bump da-parser to 2.2.0 for link-img support #202

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9dd23d
feat(shareddoc): bump da-parser to 2.2.0 for link-img support
shsteimer Sep 15, 2026
9abb779
refactor(shareddoc): revert da-parser bump, rename link-img marker
shsteimer Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions test/shareddoc.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3302,4 +3302,22 @@ describe('Collab Test Suite', () => {
persistence.update = savedUpdate;
}
});

it('Test link-img image round-trips through doc2aem/aem2doc', async () => {
const html = `
<body>
<header></header>
<main><div><a href="http://www.foo.com/myimg.jpg" title="Img Alt" data-edit-as="image">http://www.foo.com/myimg.jpg</a></div></main>
<footer></footer>
</body>
`;

const ydoc = new Y.Doc();
aem2doc(html, ydoc);

const result = doc2aem(ydoc);
assert.equal(result, html);
assert(!result.includes('<picture>'), 'link-img must serialize as a plain <a>, not <picture>');
assert(result.includes('data-edit-as="image"'));
});
});
Loading