Skip to content

GROOVY-12429: GroovyConsole error link does not place the caret on the reported column - #2948

Open
daniellansun wants to merge 1 commit into
masterfrom
GROOVY-12429
Open

daniellansun wants to merge 1 commit into
masterfrom
GROOVY-12429

Conversation

@daniellansun

Copy link
Copy Markdown
Contributor

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.7454%. Comparing base (40e59c5) to head (1cdf9f5).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2948        +/-   ##
==================================================
+ Coverage     71.6067%   71.7454%   +0.1387%     
- Complexity      38062      38118        +56     
==================================================
  Files            1588       1588                
  Lines          137078     137114        +36     
  Branches        25507      25514         +7     
==================================================
+ Hits            98157      98373       +216     
+ Misses          30014      29818       -196     
- Partials         8907       8923        +16     
Files with missing lines Coverage Δ
...e/src/main/groovy/groovy/console/ui/Console.groovy 17.8475% <100.0000%> (+17.8475%) ⬆️

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

JMH summary — classic (commit dec050f)

Speedup vs trailing 90-day baseline on gh-pages. Higher = faster.
1.00 = in line with history. Per-benchmark ratio, geomean within group.
Time-per-op units inverted so direction is consistent. The calibrated
column divides out this runner's speed vs the baseline hardware, as
measured by Groovy-independent pure-Java ruler benchmarks.

Group Speedup Calibrated n
bench 0.959 × 1.007 × 124
core 1.158 × 1.088 × 108
grails 1.121 × 0.988 × 80

No benchmark is ≥1.5× slower than its 90-day baseline.

⚠️ Runner speed differs ≥15% from the historical baseline hardware for: grails-ad. Raw speedups are not meaningful for those parts — use the calibrated column.

Runner calibration (this run vs baseline hardware): bench 0.95× (27 rulers) · core-ag 1.06× (3 rulers) · core-hz 1.08× (3 rulers) · grails-ad 1.42× (3 rulers) · grails-ez 0.95× (3 rulers)

Baseline: dev/bench/jmh/<part>/classic/data.js on gh-pages, trailing 90 days. Daily dashboard · Per-suite raw data

@github-actions

Copy link
Copy Markdown
Contributor

JMH summary — indy (commit dec050f)

Speedup vs trailing 90-day baseline on gh-pages. Higher = faster.
1.00 = in line with history. Per-benchmark ratio, geomean within group.
Time-per-op units inverted so direction is consistent. The calibrated
column divides out this runner's speed vs the baseline hardware, as
measured by Groovy-independent pure-Java ruler benchmarks.

Group Speedup Calibrated n
bench 1.031 × 1.118 × 124
core 2.698 × 2.651 × 108
grails 2.069 × 2.093 × 80

No benchmark is ≥1.5× slower than its 90-day baseline.

Runner calibration (this run vs baseline hardware): bench 0.94× (27 rulers) · core-ag 1.06× (3 rulers) · core-hz 0.95× (3 rulers) · grails-ad 1.07× (3 rulers) · grails-ez 0.93× (3 rulers)

Baseline: dev/bench/jmh/<part>/indy/data.js on gh-pages, trailing 90 days. Daily dashboard · Per-suite raw data

@testlens-app

testlens-app Bot commented Sep 25, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: 1cdf9f5
▶️ Tests: 120371 executed
⚪️ Checks: 32/32 completed


Learn more about TestLens at testlens.app/docs.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants