Conversation
Usernames are substituted into LDAP search filters and into user DN patterns when building candidate bind DNs, and group DNs resolved from the directory are substituted into the membership filter. Escape those values per RFC 4515 and RFC 4514 so the directory reads them literally, substitute placeholders literally so that '$' and '\' in a username are taken as-is, and accept distinguished names that carry no comma.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Usernames are substituted into LDAP search filters and into user DN patterns when building candidate bind DNs, and group DNs resolved from the directory are substituted into the membership filter. Escape those values per RFC 4515 and RFC 4514 so the directory reads them literally, substitute placeholders literally so that
$and\in a username are taken as-is, and accept distinguished names that carry no comma.How was this patch tested?
Added new regression tests.
Was this patch assisted by generative AI tooling?
Assisted-by: OpenCode (GLM-5.3-Flash, MiMo-V2.6-Pro)