Skip to content

Fix/bidi stream timeout - #3929

Open
sbaluja wants to merge 5 commits into
mainfrom
fix/bidi-stream-timeout
Open

sbaluja wants to merge 5 commits into
mainfrom
fix/bidi-stream-timeout

Conversation

@sbaluja

@sbaluja sbaluja commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Issue #, if available:
#3923

Description of changes:
Re-introducing the timeout removed in #3919, however with slightly different behavior:

  • timeout applies to each individual write
  • timeout applies until first byte received, and then we disregard it as to not cancel good streams with slow responses

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbaluja
sbaluja added this pull request to the merge queue Sep 21, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 21, 2026
@sbaluja
sbaluja enabled auto-merge September 22, 2026 15:03
@sbaluja
sbaluja disabled auto-merge September 22, 2026 15:10
…o-first-byte) (#XXXX)

HttpWriteDataStreamBuf bounds each write by requestTimeoutMs and bounds the wait for the first response byte; once a response arrives the wait is unbounded so healthy long-lived streams are not cut. On timeout it closes the connection to drive the real CRT completion callback (never fabricates completion). Both the smithy task and the legacy path signal NotifyResponseStarted() on headers.
@sbaluja
sbaluja force-pushed the fix/bidi-stream-timeout branch from 6b26f99 to 6512a7c Compare September 22, 2026 15:10

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants