Build MinIO test image from source - #2116
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tesshuflower The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- minio has stopped making built images available - build a minio image directly for e2e and local dev called 'volsync-test-storage'. - for custom scorecard tests where we also need minio, pull the binaries from the 'volsync-test-storage' image into the scorecard image itself so scorecard image can be used to run minio. - To keep this change minimal for the moment, not changing the minio helm charts themselves, just the image we reference. Signed-off-by: Tesshu Flower <tflower@redhat.com>
b29a15c to
e3eb9a4
Compare
|
|
/lgtm |
|
/override "ci/prow/e2e-openshift" Will need updates in prow to build minio for openshift e2e tests - so overriding the check |
|
@tesshuflower: Overrode contexts on behalf of tesshuflower: ci/prow/e2e-openshift DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "ci/prow/e2e-openshift-fips" |
|
@tesshuflower: Overrode contexts on behalf of tesshuflower: ci/prow/e2e-openshift-fips, ci/prow/e2e-openshift-helm DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2116 +/- ##
=======================================
- Coverage 68.8% 68.7% -0.1%
=======================================
Files 58 58
Lines 6076 6076
=======================================
- Hits 4184 4178 -6
- Misses 1582 1585 +3
- Partials 310 313 +3 🚀 New features to boost your workflow:
|
backport of: backube#2116 Signed-off-by: Tesshu Flower <tflower@redhat.com>
backport of: backube#2116 Signed-off-by: Tesshu Flower <tflower@redhat.com>
3 participants
Describe what this PR does
Is there anything that requires special attention?
We will still need a pr to openshift/release for the openshift e2e CI tests run by prow. These will also need to be updated to build minio.
Related issues: