Skip to content

Add ChatGPT device login E2E coverage - #21

Merged
beiwei30 merged 1 commit into
mainfrom
codex/chatgpt-auth-device-e2e
Aug 20, 2026
Merged

beiwei30 merged 1 commit into
mainfrom
codex/chatgpt-auth-device-e2e

Conversation

@beiwei30

Copy link
Copy Markdown
Owner

Summary

  • add a real CLI loopback E2E for the ChatGPT device-code flow
  • verify flushed instructions, 404/403 pending handling, one-second polling, and the final authorization-code exchange
  • verify 0600 credential persistence, restart-visible active status, no extra status requests, and secret redaction
  • extend the shared auth harness with request timestamps and configurable device authorization values

Verification

  • cargo test -p orbcode --test chatgpt_auth_device_e2e
  • cargo test -p orbcode-config openai_oauth::tests::device
  • cargo test -p orbcode-config chatgpt_credentials_round_trip
  • cargo fmt --all --check
  • cargo clippy -p orbcode --test chatgpt_auth_device_e2e -- -D warnings
  • cargo test -p orbcode --test chatgpt_auth_browser_e2e
  • cargo test -p orbcode --test chatgpt_auth_harness_e2e
  • git diff --check

Mutation checks

The focused E2E was confirmed to fail when instruction flushing was removed, 404 pending became terminal, polling delay was removed, or the device callback URI was changed.

@beiwei30
beiwei30 marked this pull request as ready for review August 20, 2026 08:55
Copilot AI lite review requested due to automatic review settings August 20, 2026 08:55
@beiwei30
beiwei30 merged commit 7ab9d18 into main Aug 20, 2026
2 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@beiwei30
beiwei30 deleted the codex/chatgpt-auth-device-e2e branch August 20, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants