Skip to content

Cover ChatGPT auth failure and cancellation - #22

Merged
beiwei30 merged 2 commits into
mainfrom
codex/chatgpt-auth-p1-03
Aug 20, 2026
Merged

beiwei30 merged 2 commits into
mainfrom
codex/chatgpt-auth-p1-03

Conversation

@beiwei30

Copy link
Copy Markdown
Owner

Summary

  • Add deterministic CLI E2E coverage for browser and device-login failure, timeout, and cancellation paths.
  • Prove authentication state stays unchanged while callback listeners and helper processes are cleaned up.
  • Harden OAuth response validation and keep provider-controlled errors bounded and redacted.

Verification

  • cargo test -p orbcode --test chatgpt_auth_failure_e2e
  • cargo test -p orbcode --test chatgpt_auth_browser_e2e --test chatgpt_auth_device_e2e
  • cargo test -p orbcode-config openai_oauth
  • cargo clippy -p orbcode-config -p orbcode --tests -- -D warnings
  • scripts/check.sh
  • git diff --check

Plan

Implements P1-03 from chatgpt-auth-p1-03-failure-cancellation-plan.md.

@beiwei30
beiwei30 marked this pull request as ready for review August 20, 2026 09:56
Copilot AI lite review requested due to automatic review settings August 20, 2026 09:56
@beiwei30
beiwei30 merged commit 1a72bac into main Aug 20, 2026
2 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@beiwei30
beiwei30 deleted the codex/chatgpt-auth-p1-03 branch August 20, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants