Conversation
holmanb
requested changes
Sep 1, 2026
sshedi
force-pushed
the
fix-mypy-distros-tests
branch
3 times, most recently
from
September 4, 2026 14:51
ea2baa8 to
7779052
Compare
sshedi
force-pushed
the
fix-mypy-distros-tests
branch
from
September 11, 2026 08:10
7779052 to
a4d637a
Compare
holmanb
requested changes
Sep 14, 2026
| @@ -1,4 +1,5 @@ | |||
| # This file is part of cloud-init. See LICENSE file for license information. | |||
|
|
|||
Member
There was a problem hiding this comment.
Please avoid unnecessary whitespace changes
|
|
||
| self._ifs_by_mac = dict(ifs_by_mac) | ||
| return {**self._ifs_by_name, **self._ifs_by_mac} | ||
| return self._ifs_by_name |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
sshedi
force-pushed
the
fix-mypy-distros-tests
branch
from
September 16, 2026 11:33
a4d637a to
9a7b294
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Test Steps
Merge type