refactor(ci): move integration-test common steps into composite action - #7070
blackboxsw wants to merge 2 commits into
Conversation
Replace the reusable workflow .github/workflows/100-dispatch-common.yml with a composite action .github/actions/integration-test containing shared integration-test steps (secret assertion, checkout, LXD/SSH/ pycloudlib setup, tox run, report publish, cleanup). This allows platform-specific secret changes and pre-flight workflow steps such as credential file setup in subsequent workflows avoiding pulling in platform-specific setup into the common integration testing. Behavior is preseved. Update all existing platform workflows to now pass in environment variables to the composite action the boundary from workflow to composite action doesn't allow passing workflow `secrets`. Additionally, to run composite actions a preliminary checkout step is required in the scheduled workflow to provide visibility to the .github/actions dir.
holmanb
left a comment
holmanb
left a comment
There was a problem hiding this comment.
I assume that there is something missing in this PR - I don't see the action file that is referred to by the workflows.
9d655f7 to
42d8456
Compare
holmanb
left a comment
holmanb
left a comment
There was a problem hiding this comment.
There are OCI references throughout this PR - please drop them. See my other inline comments.
Has this been tested?
| resulting JUnit report. OCI-specific secret validation and credential | ||
| setup are NOT handled here; OCI callers must assert and write the OCI | ||
| config/key to the runner temp directory (passed via runner_temp) before invoking this action. |
There was a problem hiding this comment.
Saying what isn't handled here is redundant and likely to become stale.
Also, OCI is not included in this PR.
| The runner's temp directory (runner.temp). Passed by the caller | ||
| because the runner context is not available inside a composite action's | ||
| runs section at load time. |
There was a problem hiding this comment.
because the runner context is not available inside a composite action's
Is that actually true? If it is that would mean that every published github action would require passing this in - and I don't see other github actions requiring this argument.
This seems suspect, at the very least.
| github-report: true | ||
| artifact-name: ctrf-report-${{ inputs.platform }}-${{ inputs.release }} | ||
| env: | ||
| GITHUB_TOKEN: ${{ env.GITHUB_TOKEN }} |
There was a problem hiding this comment.
If this is ommitted, won't the report step will fail?
2 participants
Propsed commit message
Additional Context
Split out from #6969
Test Steps
Merge type