keyboard: keep the computed note inside the MIDI range - #261
Merged
Merged
Conversation
The octave was clamped to 0..127 while note_on takes a uint8_t, so from the default octave seven presses of OCTAVE_PLUS produced notes above 127, which truncated on the way out. Nine is the highest octave the default map fits inside the range; the note is checked as well, since the scancode map is the caller's to replace. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PWVTQ1pm3X2Uz7goFgULtC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The octave is clamped to 0..127 while note_on takes a uint8_t, so from the default octave seven presses of OCTAVE_PLUS produce notes above 127, which truncate on the way out. Downstream that indexed a 128-entry table and aborted.
Nine is the highest octave the default map fits inside the range; the note is checked too, since the scancode map is the caller's to replace.
For ossia/score#2298.