Conversation
The note said cert-manager should also work with v1beta1 and v1alpha2 because of resource conversion, which reads as though a cluster serving only those versions is supported. It is not: cert-manager resolves gwapi.GroupVersion from sigs.k8s.io/gateway-api/apis/v1 and calls ServerResourcesForGroupVersion on it at startup, refusing to start when the v1 CRDs are absent, and the Gateway shim watches Gateway().V1().Gateways(). Say that the v1 CRDs are required, and keep the part that is true: the Gateway manifests themselves may still be written as v1beta1 or v1alpha2, because the API server converts between versions. Signed-off-by: m-altaifi <magic.moha@icloud.com>
cert-manager-prow
Bot
added
the
dco-signoff: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
cert-manager-prow
Bot
added
the
size/M
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1623.
The note currently reads:
That reads as though a cluster serving only
v1beta1/v1alpha2is supported. It isn't — cert-manager will not start:pkg/controller/context.goimportsgwapi "sigs.k8s.io/gateway-api/apis/v1"and callsd.ServerResourcesForGroupVersion(gwapi.GroupVersion.String())at startup, returningthe Gateway API CRDs do not seem to be present, but ExperimentalGatewayAPISupport is set to truewhen they are not.ctx.GWShared.Gateway().V1().Gateways(), sogateway.networking.k8s.io/v1is the only version it lists and watches.That is exactly the crash loop reported in cert-manager/cert-manager#6649, and the resolution there was that the cluster had to serve the v1 CRDs. Once they are installed, the reporters confirmed that Gateway resources authored as
v1beta1work fine, which is the part of the original sentence worth keeping.So the replacement says the v1 CRDs are required, and that your own Gateway manifests may still be
v1beta1/v1alpha2because the API server converts between versions.The same paragraph appears in
usage/gateway.mdandconfiguration/acme/http01/README.md. Per the repo README ("add it todocs/and possibly to the specific version of cert-manager that's latest"), I changedcontent/docs/andcontent/v1.19-docs/. The identical text is also in the v1.11–v1.18 snapshots; I left those alone as frozen docs for released versions, but happy to extend if you would rather have them consistent.Testing
npm ci, then against the four changed files:cspell0 issues,remark --frailexit 0. No links were added or changed.