Correctly ignore tasks without a payload in Task.tasks_from_queue - #382
Merged
Merged
Conversation
thomasst
approved these changes
Sep 24, 2026
wojcikstefan
approved these changes
Sep 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug in
Task.tasks_from_queue:When
include_not_found=False, if a task ID exists in the queues but doesn't carry a payload anymore,tasks_from_queuewould process it with the payload from the previous task! Or, if it was the first one in the queue, it would raise an error. Now they are truly skipped.