Skip to content

fix presets menu hierarchy with equally named submenus - #22411

Open
zisoft wants to merge 1 commit into
darktable-org:masterfrom
zisoft:fix-preset-menu-hierarchy
Open

zisoft wants to merge 1 commit into
darktable-org:masterfrom
zisoft:fix-preset-menu-hierarchy

Conversation

@zisoft

@zisoft zisoft commented Sep 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

gtk3 flattens GtkPopoverMenu into a single GtkStack and names each page after its item label, so equally named submenus under different presets collide and navigation follows the first one.
Solution is to give submenus unique names.

Referenced issue

fixes #22398

Checklist

  • I have read CONTRIBUTING.md and the coding style.
  • I have not merged master into the topic branch.
  • The pull request is one logical change, and every commit compiles on its own.
  • I ran the relevant tests: unit tests, src/tests/integration/ where the pixelpipe is touched, or darktable-cli as a headless smoke test.
  • New user-visible strings use _(), new preferences are registered in data/darktableconfig.xml.in.
  • A RELEASE_NOTES.md entry was added (only needed if fixing an issue in a release). Do not reference GitHub issues.

@zisoft zisoft added bugfix pull request fixing a bug gtk4 labels Sep 26, 2026
@lefth

lefth commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Thank you, this works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix pull request fixing a bug gtk4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preset choosing: a different subcategory with the same partial name is opened

2 participants