Skip to content

Crash while deleting referenced entity type #1242

Description

@loganmcbroom

Deleting an entity from the project entities tab (not an instance of an entity within a level) while another entity stores a reference to an entity of that type within a level causes a crash.

Stack:

LDtk version: 1.5.3-64bits
Cannot read properties of undefined (reading 'width')
TypeError
TypeError: Cannot read properties of undefined (reading 'width')
    at display_FieldInstanceRender.renderField (file:///C:/Users/Logan/AppData/Local/Programs/ldtk/resources/app.asar/assets/js/renderer.js:68946:119)
    at display_FieldInstanceRender.renderFields (file:///C:/Users/Logan/AppData/Local/Programs/ldtk/resources/app.asar/assets/js/renderer.js:66707:40)
    at display_EntityRender.renderFields (file:///C:/Users/Logan/AppData/Local/Programs/ldtk/resources/app.asar/assets/js/renderer.js:65069:31)
    at display_EntityRender.renderAll (file:///C:/Users/Logan/AppData/Local/Programs/ldtk/resources/app.asar/assets/js/renderer.js:65040:8)
    at new display_EntityRender (file:///C:/Users/Logan/AppData/Local/Programs/ldtk/resources/app.asar/assets/js/renderer.js:64597:7)
    at display_LayerRender.render (file:///C:/Users/Logan/AppData/Local/Programs/ldtk/resources/app.asar/assets/js/renderer.js:70412:29)
    at display_LevelRender.renderLayer (file:///C:/Users/Logan/AppData/Local/Programs/ldtk/resources/app.asar/assets/js/renderer.js:79943:7)
    at display_LevelRender.updateInvalidations (file:///C:/Users/Logan/AppData/Local/Programs/ldtk/resources/app.asar/assets/js/renderer.js:80706:11)
    at display_LevelRender.postUpdate (file:///C:/Users/Logan/AppData/Local/Programs/ldtk/resources/app.asar/assets/js/renderer.js:81153:8)
    at dn_Process._doPostUpdate (file:///C:/Users/Logan/AppData/Local/Programs/ldtk/resources/app.asar/assets/js/renderer.js:495:4)

Processes:

#0 App
 |--- #4 page.Editor
       |--- #5 misc.FileWatcher
       |--- #6 display.WorldRender
       |--- #7 display.LevelRender
       |--- #8 display.Camera
       |--- #9 display.Rulers[--]
       |--- #10 tool.SelectionTool[--]
       |--- #11 tool.lt.DoNothing[--]
       |--- #12 WorldTool
       |--- #13 tool.PanView[--]
       |--- #14 tool.lt.IntGridTool [PAUSED][--]
       |--- #98 tool.lt.EntityTool[--]
       |--- #2533 tool.lt.TileTool [PAUSED][--]
       |--- #5772 tool.lt.TileTool [PAUSED][--]
       |--- #9140 display.EntityRender
       |--- #9141 display.EntityRender
       |--- #9142 display.EntityRender
       |--- #9143 display.EntityRender
       |--- #9144 display.EntityRender
       |--- #9145 display.EntityRender
       |--- #9146 display.EntityRender
       |--- #9147 display.EntityRender
       |--- #9148 display.EntityRender
       |--- #9149 display.EntityRender
       |--- #9150 display.EntityRender
       |--- #9151 display.EntityRender
       |--- #9152 display.EntityRender
       |--- #9153 display.EntityRender
       |--- #9154 display.EntityRender
       |--- #9155 display.EntityRender
       |--- #9156 display.EntityRender
       |--- #9157 display.EntityRender
       |--- #9158 display.EntityRender
       |--- #9159 display.EntityRender
       |--- #9160 display.EntityRender
       |--- #9161 display.EntityRender
       |--- #9162 display.EntityRender
       |--- #9163 display.EntityRender
       |--- #9164 display.EntityRender
       |--- #9165 display.EntityRender
       |--- #9166 display.EntityRender
       |--- #9167 display.EntityRender
       |--- #9168 display.EntityRender
       |--- #9178 ui.modal.panel.EditEntityDefs
       |--- #9183 ui.modal.dialog.Confirm
       |--- #9184 ui.LastChance
       |--- #9185 display.EntityRender
       |--- #9186 display.EntityRender
       |--- #9187 display.EntityRender
       |--- #9188 display.EntityRender
       |--- #9189 display.EntityRender
       |--- #9190 display.EntityRender
       |--- #9191 display.EntityRender
       |--- #9192 display.EntityRender
       |--- #9193 display.EntityRender
       |--- #9194 display.EntityRender
       |--- #9195 display.EntityRender
       |--- #9196 display.EntityRender
       |--- #9197 display.EntityRender
       |--- #9198 display.EntityRender
       |--- #9199 display.EntityRender
       |--- #9200 display.EntityRender
       |--- #9201 display.EntityRender
       |--- #9202 display.EntityRender
       |--- #9203 display.EntityRender
       |--- #9204 display.EntityRender
       |--- #9205 display.EntityRender
       |--- #9206 display.EntityRender
       |--- #9207 display.EntityRender
       |--- #9208 display.EntityRender
       |--- #9209 display.EntityRender
       |--- #9210 display.EntityRender

Log:

[GENERAL]      Progress created.
[RENDER]       Rendering world bg...
[GENERAL]      Progress started: : "Saving main file...", 2 operation(s)
[SAVE]           Preparing SavingData...
[SAVE]           Writing C:/Users/Logan/Documents/Source/game/assets/levels/test_world_40x22.ldtk...
[GENERAL]      Progress completed: "Saving main file..." (0s)
[FILE]         Emptying dir C:/Users/Logan/Documents/Source/game/assets/levels/test_world_40x22 (onlyExts=[ldtkl])...
[SAVE]         => Done...
[SAVE]         Saving complete (test_world_40x22.ldtk)
[FILE]         Saved "test_world_40x22.ldtk".
[EVENT]        ProjectSaved
[RENDER]       Rendering world bg...
[RENDER]       Rendering world bg...
[RENDER]       Rendering world bg...
[RENDER]       Rendering world bg...
[USERACTION]   Opened panel #9178 ui.modal.panel.EditEntityDefs
[FILE]         Reading HTML template editEntityDefs from cache
[FILE]         Reading HTML template fieldDefsForm from cache
[FILE]         Reading HTML template pivotEditor from cache
[RENDER]       Rendering world bg...
[RENDER]       Rendering world bg...
[RENDER]       Rendering world bg...
[RENDER]       Rendering world bg...
[RENDER]       Rendering world bg...
[RENDER]       Rendering world bg...
[WARNING]      Last chance for: Entity ToggleTile deleted
[TIDY]         Removed lost entity in LayerInst#18 "Objects" [Entities]
[TIDY]         Removed lost entity in LayerInst#18 "Objects" [Entities]
[TIDY]         Removed lost entity in LayerInst#18 "Objects" [Entities]
[EVENT]        EntityDefRemoved
[EVENT]        LevelJsonCacheInvalidated
[EVENT]        LevelJsonCacheInvalidated
[EVENT]        LevelJsonCacheInvalidated
[EVENT]        LevelJsonCacheInvalidated
[EVENT]        LevelJsonCacheInvalidated
[EVENT]        LevelJsonCacheInvalidated
[EVENT]        LevelJsonCacheInvalidated
[EVENT]        LevelJsonCacheInvalidated
[EVENT]        LevelJsonCacheInvalidated
[EVENT]        LevelJsonCacheInvalidated
[FILE]         Reading HTML template pivotEditor from cache
[FILE]         Reading HTML template pivotEditor from cache
[GENERAL]      Page started: page.CrashReport()
[FILE]         Loading page template: crashReport from C:/Users/Logan/AppData/Local/Programs/ldtk/resources/app.asar/assets/tpl/pages/crashReport.html
[ERROR]        Cannot read properties of undefined (reading 'width') (TypeError)
[ERROR]        TypeError: Cannot read properties of undefined (reading 'width')
    at display_FieldInstanceRender.renderField (file:///C:/Users/Logan/AppData/Local/Programs/ldtk/resources/app.asar/assets/js/renderer.js:68946:119)
    at display_FieldInstanceRender.renderFields (file:///C:/Users/Logan/AppData/Local/Programs/ldtk/resources/app.asar/assets/js/renderer.js:66707:40)
    at display_EntityRender.renderFields (file:///C:/Users/Logan/AppData/Local/Programs/ldtk/resources/app.asar/assets/js/renderer.js:65069:31)
    at display_EntityRender.renderAll (file:///C:/Users/Logan/AppData/Local/Programs/ldtk/resources/app.asar/assets/js/renderer.js:65040:8)
    at new display_EntityRender (file:///C:/Users/Logan/AppData/Local/Programs/ldtk/resources/app.asar/assets/js/renderer.js:64597:7)
    at display_LayerRender.render (file:///C:/Users/Logan/AppData/Local/Programs/ldtk/resources/app.asar/assets/js/renderer.js:70412:29)
    at display_LevelRender.renderLayer (file:///C:/Users/Logan/AppData/Local/Programs/ldtk/resources/app.asar/assets/js/renderer.js:79943:7)
    at display_LevelRender.updateInvalidations (file:///C:/Users/Logan/AppData/Local/Programs/ldtk/resources/app.asar/assets/js/renderer.js:80706:11)
    at display_LevelRender.postUpdate (file:///C:/Users/Logan/AppData/Local/Programs/ldtk/resources/app.asar/assets/js/renderer.js:81153:8)
    at dn_Process._doPostUpdate (file:///C:/Users/Logan/AppData/Local/Programs/ldtk/resources/app.asar/assets/js/renderer.js:495:4)

[GENERAL]      
#0 App
 |--- #4 page.Editor
       |--- #5 misc.FileWatcher
       |--- #6 display.WorldRender
       |--- #7 display.LevelRender
       |--- #8 display.Camera
       |--- #9 display.Rulers[--]
       |--- #10 tool.SelectionTool[--]
       |--- #11 tool.lt.DoNothing[--]
       |--- #12 WorldTool
       |--- #13 tool.PanView[--]
       |--- #14 tool.lt.IntGridTool [PAUSED][--]
       |--- #98 tool.lt.EntityTool[--]
       |--- #2533 tool.lt.TileTool [PAUSED][--]
       |--- #5772 tool.lt.TileTool [PAUSED][--]
       |--- #9140 display.EntityRender
       |--- #9141 display.EntityRender
       |--- #9142 display.EntityRender
       |--- #9143 display.EntityRender
       |--- #9144 display.EntityRender
       |--- #9145 display.EntityRender
       |--- #9146 display.EntityRender
       |--- #9147 display.EntityRender
       |--- #9148 display.EntityRender
       |--- #9149 display.EntityRender
       |--- #9150 display.EntityRender
       |--- #9151 display.EntityRender
       |--- #9152 display.EntityRender
       |--- #9153 display.EntityRender
       |--- #9154 display.EntityRender
       |--- #9155 display.EntityRender
       |--- #9156 display.EntityRender
       |--- #9157 display.EntityRender
       |--- #9158 display.EntityRender
       |--- #9159 display.EntityRender
       |--- #9160 display.EntityRender
       |--- #9161 display.EntityRender
       |--- #9162 display.EntityRender
       |--- #9163 display.EntityRender
       |--- #9164 display.EntityRender
       |--- #9165 display.EntityRender
       |--- #9166 display.EntityRender
       |--- #9167 display.EntityRender
       |--- #9168 display.EntityRender
       |--- #9178 ui.modal.panel.EditEntityDefs
       |--- #9183 ui.modal.dialog.Confirm
       |--- #9184 ui.LastChance
       |--- #9185 display.EntityRender
       |--- #9186 display.EntityRender
       |--- #9187 display.EntityRender
       |--- #9188 display.EntityRender
       |--- #9189 display.EntityRender
       |--- #9190 display.EntityRender
       |--- #9191 display.EntityRender
       |--- #9192 display.EntityRender
       |--- #9193 display.EntityRender
       |--- #9194 display.EntityRender
       |--- #9195 display.EntityRender
       |--- #9196 display.EntityRender
       |--- #9197 display.EntityRender
       |--- #9198 display.EntityRender
       |--- #9199 display.EntityRender
       |--- #9200 display.EntityRender
       |--- #9201 display.EntityRender
       |--- #9202 display.EntityRender
       |--- #9203 display.EntityRender
       |--- #9204 display.EntityRender
       |--- #9205 display.EntityRender
       |--- #9206 display.EntityRender
       |--- #9207 display.EntityRender
       |--- #9208 display.EntityRender
       |--- #9209 display.EntityRender
       |--- #9210 display.EntityRender
 |--- #9211 page.CrashReport

[FILE]         Cleared all file watches

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions