tests: Fix deprecation warning for utcfromtimestamp() - #3354
Merged
Merged
Conversation
ricardobranco777
force-pushed
the
timezone_aware
branch
from
August 20, 2025 19:07
75479d6 to
439c15f
Compare
Contributor
Author
|
Fixes deprecation warning noticed in #3335 cc @thaJeztah |
Fix DeprecationWarning for datetime.datetime.utcfromtimestamp() It suggests to use timezone-aware objects to represent datetimes in UTC with datetime.UTC but datetime.timezone.utc is backwards compatible. Signed-off-by: Ricardo Branco <rbranco@suse.de>
ricardobranco777
force-pushed
the
timezone_aware
branch
from
August 24, 2025 15:07
439c15f to
6efb722
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The focused test updates correctly eliminate the warnings without changing expected behavior.
Pull request overview
Updates datetime-based API tests to avoid Python’s deprecated utcfromtimestamp() while preserving UTC behavior.
Changes:
- Replaces deprecated calls with timezone-aware
fromtimestamp(..., timezone.utc). - Keeps expected Unix timestamps unchanged.
File summaries
| File | Description |
|---|---|
tests/unit/api_test.py |
Updates event time-range test. |
tests/unit/api_container_test.py |
Updates container log timestamp test. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vvoland
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix DeprecationWarning for
datetime.datetime.utcfromtimestamp()It suggests to use timezone-aware objects to represent datetimes in UTC with
datetime.UTCbutdatetime.timezone.utcis backwards compatible.Verification run: https://openqa.opensuse.org/tests/5261910#downloads