Conversation
Bail out before unrolling when the analyzed loop test is not the branch condition, avoiding a Checked assert and Release MinOpts fallback. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
area-CodeGen-coreclr
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
Author
|
PTAL @jakobbotsch @dotnet/jit-contrib no diffs |
Member
|
Should the support for this shape rather be removed from |
Instead of bailing out in loop unrolling, stop recognizing loop tests evaluated into a temp. This shape has no SPMI diffs and its partial support led to the unroll precondition failure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9cae45a2-8eb1-4625-a0bf-fbe425c2dac8
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bail out before unrolling when the analyzed loop test is not the branch condition, avoiding a Checked assert and Release MinOpts fallback.Fixes #134934
Diffs