Skip to content

migrate from inject to service named import in @ember/service - #1709

Merged
MinThaMie merged 1 commit into
ember-learn:mainfrom
jelhan:fix-inject-service-deprecation
Sep 23, 2026
Merged

MinThaMie merged 1 commit into
ember-learn:mainfrom
jelhan:fix-inject-service-deprecation

Conversation

@jelhan

@jelhan jelhan commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

The service named export has been added in v4.1 as an alternative to inject. The inject named export was deprecated in the v6 cycle and dropped in 7.0.

This should not be a breaking change as ember-cli-addon-docs already requires Ember v4.8+.

This is required for Ember v7 compatibility. But I have not tested if it is the only needed change.

@MinThaMie
MinThaMie self-requested a review September 23, 2026 14:56

@MinThaMie MinThaMie left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this work!

@MinThaMie
MinThaMie merged commit e384584 into ember-learn:main Sep 23, 2026
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants