Cherry-pick #779, #781 to main - #782
Merged
Merged
Conversation
bbhtt
changed the title
smcv
reviewed
Sep 15, 2026
smcv
left a comment
smcv
left a comment
Contributor
There was a problem hiding this comment.
1.4.x to 1.5.x is surely a forward-port rather than a backport? But the code changes look about right. Let me try this on a system that has appstream 1.2.0.
This is the same as assert_file_has_content, but uses POSIX extended regexps (`grep -E`) instead of basic regexps (plain `grep`). Signed-off-by: Simon McVittie <smcv@debian.org>
This made it feasible to diagnose #776. Signed-off-by: Simon McVittie <smcv@debian.org>
Collaborator
Author
|
Thanks added those commits. |
smcv
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.